Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 2079283002: [iOS/GN] Allow compilation with system clang. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Pass -isystem when building with system clang on iOS Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/nacl/config.gni") 8 import("//build/config/nacl/config.gni")
9 import("//build/toolchain/cc_wrapper.gni") 9 import("//build/toolchain/cc_wrapper.gni")
10 import("//build/toolchain/toolchain.gni") 10 import("//build/toolchain/toolchain.gni")
(...skipping 989 matching lines...) Expand 10 before | Expand all | Expand 10 after
1000 1000
1001 # TODO(thakis): This used to be implied by -Wno-unused-function, 1001 # TODO(thakis): This used to be implied by -Wno-unused-function,
1002 # which we no longer use. Check if it makes sense to remove 1002 # which we no longer use. Check if it makes sense to remove
1003 # this as well. http://crbug.com/316352 1003 # this as well. http://crbug.com/316352
1004 "-Wno-unneeded-internal-declaration", 1004 "-Wno-unneeded-internal-declaration",
1005 1005
1006 # TODO(hans): Get this cleaned up, http://crbug.com/428099 1006 # TODO(hans): Get this cleaned up, http://crbug.com/428099
1007 "-Wno-inconsistent-missing-override", 1007 "-Wno-inconsistent-missing-override",
1008 ] 1008 ]
1009 1009
1010 # NaCl's Clang compiler and Chrome's hermetic Clang compiler will almost 1010 # Chrome's hermetic Clang compiler, NaCl's Clang compiler and system
1011 # always have different versions. Certain flags may not be recognized by 1011 # Clang compiler will almost have different version. Certain flags may
Dirk Pranke 2016/06/20 16:31:22 s/and system/and the system/ and s/almost have d
sdefresne 2016/06/21 11:31:29 Done.
1012 # one version or the other. 1012 # not be recognized by one version or the other.
1013 if (!is_nacl) { 1013 if (!is_nacl) {
1014 # Flags NaCl (Clang 3.7) does not recognize. 1014 # Flags NaCl (Clang 3.7) does not recognize.
1015 cflags += [ 1015 cflags += [
1016 # TODO(thakis): Enable this, crbug.com/507717 1016 # TODO(thakis): Enable this, crbug.com/507717
1017 "-Wno-shift-negative-value", 1017 "-Wno-shift-negative-value",
1018
1019 # TODO(thakis): https://crbug.com/604888
1020 "-Wno-undefined-var-template",
1021 ] 1018 ]
1022 1019
1023 if (llvm_force_head_revision) { 1020 if (llvm_force_head_revision) {
1024 cflags += [ 1021 cflags += [
1025 # TODO(thakis): https://crbug.com/617318 1022 # TODO(thakis): https://crbug.com/617318
1026 "-Wno-nonportable-include-path", 1023 "-Wno-nonportable-include-path",
1027 ] 1024 ]
1028 } 1025 }
1029 } 1026 }
1027 if (!is_nacl && !use_system_clang) {
1028 # Flags NaCl (Clang 3.7) does not recognize.
1029 cflags += [
1030 # TODO(thakis): https://crbug.com/604888
1031 "-Wno-undefined-var-template",
1032 ]
1033 }
1030 } 1034 }
1031 } 1035 }
1032 1036
1033 # chromium_code --------------------------------------------------------------- 1037 # chromium_code ---------------------------------------------------------------
1034 # 1038 #
1035 # Toggles between higher and lower warnings for code that is (or isn't) 1039 # Toggles between higher and lower warnings for code that is (or isn't)
1036 # part of Chromium. 1040 # part of Chromium.
1037 1041
1038 config("chromium_code") { 1042 config("chromium_code") {
1039 if (is_win) { 1043 if (is_win) {
(...skipping 461 matching lines...) Expand 10 before | Expand all | Expand 10 after
1501 1505
1502 if (is_ios || is_mac) { 1506 if (is_ios || is_mac) {
1503 # On Mac and iOS, this enables support for ARC (automatic ref-counting). 1507 # On Mac and iOS, this enables support for ARC (automatic ref-counting).
1504 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html. 1508 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html.
1505 config("enable_arc") { 1509 config("enable_arc") {
1506 common_flags = [ "-fobjc-arc" ] 1510 common_flags = [ "-fobjc-arc" ]
1507 cflags_objc = common_flags 1511 cflags_objc = common_flags
1508 cflags_objcc = common_flags 1512 cflags_objcc = common_flags
1509 } 1513 }
1510 } 1514 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698