Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 2079273005: [Extensions] Add more fine-grained extension performance metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Mark's Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « extensions/browser/extension_function.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index d02f2bee6c44aa65f3acdad464229c26c46b5b53..e975edf60b55d57955dcbcf0814cc62e775d9305 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -14216,6 +14216,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<summary>Number of calls to extension functions.</summary>
</histogram>
+<histogram name="Extensions.Functions.FailedTime" enum="ExtensionFunctions">
+ <owner>rdevlin.cronin@chromium.org</owner>
+ <summary>
+ Recorded when an extension function call fails and finishes execution. The
+ suffix indicates the exact bucket the function is in. See also
+ Extensions.Functions.FailedTotalExecutionTime.
+ </summary>
+</histogram>
+
<histogram name="Extensions.Functions.FailedTotalExecutionTime" units="ms">
<owner>rdevlin.cronin@chromium.org</owner>
<summary>
@@ -14227,6 +14236,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="Extensions.Functions.SucceededTime" enum="ExtensionFunctions">
+ <owner>rdevlin.cronin@chromium.org</owner>
+ <summary>
+ Recorded when an extension function call succeeds and finishes execution.
+ The suffix indicates the exact bucket the function is in. See also
+ Extensions.Functions.SucceededTotalExecutionTime.
+ </summary>
+</histogram>
+
<histogram name="Extensions.Functions.SucceededTotalExecutionTime" units="ms">
<owner>rdevlin.cronin@chromium.org</owner>
<summary>
@@ -92885,6 +92903,16 @@ To add a new entry, add it with any value and run test to compute valid value.
<affected-histogram name="Stability.ExitFunnel"/>
</histogram_suffixes>
+<histogram_suffixes name="ExtensionFunctionExecutionTime" separator=".">
+ <suffix name="1msTo5ms"
+ label="Execution took between 1ms and 5ms (tolerable)."/>
+ <suffix name="5msTo10ms" label="Execution took between 5ms and 10ms (slow)."/>
+ <suffix name="LessThan1ms" label="Execution took less than 1ms (fast)."/>
+ <suffix name="Over10ms" label="Execution took over 10ms (glacial)."/>
Mark P 2016/06/23 19:05:22 love your commentary :-)
+ <affected-histogram name="Extensions.Functions.FailedTime"/>
+ <affected-histogram name="Extensions.Functions.SucceededTime"/>
+</histogram_suffixes>
+
<histogram_suffixes name="ExtensionsDatabaseOpen" separator=".">
<suffix name="Rules" label="Rules backing stores"/>
<suffix name="Settings" label="Settings backing stores"/>
« no previous file with comments | « extensions/browser/extension_function.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698