Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Issue 2079243002: binding: Removes |document| hidden value from the global object. (Closed)

Created:
4 years, 6 months ago by Yuki
Modified:
4 years, 6 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

binding: Removes |document| hidden value from the global object. We no longer need this hidden value. peria@ once removed this hidden value at https://crrev.com/1836193002 . This is the same. BUG= Committed: https://crrev.com/d7a85b756c599bb0f7e93259fd18358271e52d20 Cr-Commit-Position: refs/heads/master@{#400661}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Yuki
Could you review this CL?
4 years, 6 months ago (2016-06-20 09:35:26 UTC) #2
haraken
LGTM
4 years, 6 months ago (2016-06-20 10:47:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2079243002/1
4 years, 6 months ago (2016-06-20 10:57:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 12:37:32 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 12:38:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d7a85b756c599bb0f7e93259fd18358271e52d20
Cr-Commit-Position: refs/heads/master@{#400661}

Powered by Google App Engine
This is Rietveld 408576698