Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Issue 2079233006: [turbofan] Propagate word32 truncations through tagged-hole checks. (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Propagate word32 truncations through tagged-hole checks. If all uses of a CheckTaggedHole[convert-hole-to-undefined] node truncate to word32, we can replace the hole check with a Smi check and return the result as word32. R=jarin@chromium.org Committed: https://crrev.com/61386fb82d82ad31969ec699eb4433eec502f04e Cr-Commit-Position: refs/heads/master@{#37142}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M src/compiler/simplified-lowering.cc View 1 chunk +12 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Benedikt Meurer
4 years, 6 months ago (2016-06-21 09:49:05 UTC) #1
Benedikt Meurer
Hey Jaro, This fixes the first hole-check in Octane crypto. Please take a look. Thanks, ...
4 years, 6 months ago (2016-06-21 09:49:52 UTC) #2
Jarin
lgtm
4 years, 6 months ago (2016-06-21 11:07:52 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2079233006/1
4 years, 6 months ago (2016-06-21 12:27:09 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-21 12:31:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2079233006/1
4 years, 6 months ago (2016-06-21 12:41:50 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 12:43:56 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 12:45:31 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/61386fb82d82ad31969ec699eb4433eec502f04e
Cr-Commit-Position: refs/heads/master@{#37142}

Powered by Google App Engine
This is Rietveld 408576698