src/js/math.js - Issue 2079233005: [builtins] Make sure the Math functions and constants agree.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/js/math.js

Issue 2079233005: [builtins] Make sure the Math functions and constants agree. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Update the unittests. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/js/math.js

diff --git a/src/js/math.js b/src/js/math.js

index e8fccd224bacb7ae1b38455cf7cdbe6c8eede198..3e8490aa1567f22bb33664fcba92150632d8b707 100644

--- a/src/js/math.js

+++ b/src/js/math.js

@@ -127,15 +127,6 @@ function MathHypot(x, y) { // Function length is 2.

// Set up math constants.

utils.InstallConstants(GlobalMath, [

- // ECMA-262, section 15.8.1.1.

- "E", 2.7182818284590452354,

- // ECMA-262, section 15.8.1.2.

- "LN10", 2.302585092994046,

- // ECMA-262, section 15.8.1.3.

- "LN2", 0.6931471805599453,

- // ECMA-262, section 15.8.1.4.

- "LOG2E", 1.4426950408889634,

- "LOG10E", 0.4342944819032518,

"PI", 3.1415926535897932,

"SQRT1_2", 0.7071067811865476,

"SQRT2", 1.4142135623730951

Yang 2016/06/21 05:40:30 What about these three? Can we move them over to t

Benedikt Meurer 2016/06/21 05:42:55 Yeah, but let's do that separately. This CL is onl

« src/bootstrapper.cc ('K') | « src/bootstrapper.cc ('k') | test/mjsunit/regress/regress-crbug-621611.js » ('j') | test/unittests/base/ieee754-unittest.cc » ('J')