Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1010)

Side by Side Diff: chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc

Issue 2079233004: Add the Windows.IsPinnedToTaskbar metric. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compilation Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.h" 5 #include "chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 #endif 45 #endif
46 #endif // defined(OS_LINUX) && !defined(OS_CHROMEOS) 46 #endif // defined(OS_LINUX) && !defined(OS_CHROMEOS)
47 47
48 #if defined(USE_OZONE) || defined(USE_X11) 48 #if defined(USE_OZONE) || defined(USE_X11)
49 #include "ui/events/devices/input_device_event_observer.h" 49 #include "ui/events/devices/input_device_event_observer.h"
50 #include "ui/events/devices/input_device_manager.h" 50 #include "ui/events/devices/input_device_manager.h"
51 #endif // defined(USE_OZONE) || defined(USE_X11) 51 #endif // defined(USE_OZONE) || defined(USE_X11)
52 52
53 #if defined(OS_WIN) 53 #if defined(OS_WIN)
54 #include "base/win/windows_version.h" 54 #include "base/win/windows_version.h"
55 #include "chrome/browser/shell_integration_win.h"
55 #include "chrome/installer/util/google_update_settings.h" 56 #include "chrome/installer/util/google_update_settings.h"
56 #endif // defined(OS_WIN) 57 #endif // defined(OS_WIN)
57 58
58 namespace { 59 namespace {
59 60
60 enum UMALinuxGlibcVersion { 61 enum UMALinuxGlibcVersion {
61 UMA_LINUX_GLIBC_NOT_PARSEABLE, 62 UMA_LINUX_GLIBC_NOT_PARSEABLE,
62 UMA_LINUX_GLIBC_UNKNOWN, 63 UMA_LINUX_GLIBC_UNKNOWN,
63 UMA_LINUX_GLIBC_2_11, 64 UMA_LINUX_GLIBC_2_11,
64 // To log newer versions, just update tools/metrics/histograms/histograms.xml. 65 // To log newer versions, just update tools/metrics/histograms/histograms.xml.
(...skipping 282 matching lines...) Expand 10 before | Expand all | Expand 10 after
347 348
348 #if defined(OS_MACOSX) 349 #if defined(OS_MACOSX)
349 RecordMacMetrics(); 350 RecordMacMetrics();
350 #endif // defined(OS_MACOSX) 351 #endif // defined(OS_MACOSX)
351 352
352 const int kStartupMetricsGatheringDelaySeconds = 45; 353 const int kStartupMetricsGatheringDelaySeconds = 45;
353 content::BrowserThread::GetBlockingPool()->PostDelayedTask( 354 content::BrowserThread::GetBlockingPool()->PostDelayedTask(
354 FROM_HERE, 355 FROM_HERE,
355 base::Bind(&RecordStartupMetricsOnBlockingPool), 356 base::Bind(&RecordStartupMetricsOnBlockingPool),
356 base::TimeDelta::FromSeconds(kStartupMetricsGatheringDelaySeconds)); 357 base::TimeDelta::FromSeconds(kStartupMetricsGatheringDelaySeconds));
358 #if defined(OS_WIN)
359 content::BrowserThread::PostDelayedTask(
360 content::BrowserThread::IO, FROM_HERE,
361 base::Bind(&shell_integration::win::RecordIsPinnedToTaskbarHistogram),
362 base::TimeDelta::FromSeconds(kStartupMetricsGatheringDelaySeconds));
dcheng 2016/07/01 05:46:55 Nit: I think kStartupMetricsGatheringDelaySeconds
Patrick Monette 2016/07/04 15:36:15 Done.
363 #endif // defined(OS_WIN)
364
357 365
358 display_count_ = display::Screen::GetScreen()->GetNumDisplays(); 366 display_count_ = display::Screen::GetScreen()->GetNumDisplays();
359 UMA_HISTOGRAM_COUNTS_100("Hardware.Display.Count.OnStartup", display_count_); 367 UMA_HISTOGRAM_COUNTS_100("Hardware.Display.Count.OnStartup", display_count_);
360 display::Screen::GetScreen()->AddObserver(this); 368 display::Screen::GetScreen()->AddObserver(this);
361 is_screen_observer_ = true; 369 is_screen_observer_ = true;
362 370
363 #if !defined(OS_ANDROID) 371 #if !defined(OS_ANDROID)
364 FirstWebContentsProfiler::Start(); 372 FirstWebContentsProfiler::Start();
365 #endif // !defined(OS_ANDROID) 373 #endif // !defined(OS_ANDROID)
366 } 374 }
(...skipping 20 matching lines...) Expand all
387 } 395 }
388 } 396 }
389 397
390 namespace chrome { 398 namespace chrome {
391 399
392 void AddMetricsExtraParts(ChromeBrowserMainParts* main_parts) { 400 void AddMetricsExtraParts(ChromeBrowserMainParts* main_parts) {
393 main_parts->AddParts(new ChromeBrowserMainExtraPartsMetrics()); 401 main_parts->AddParts(new ChromeBrowserMainExtraPartsMetrics());
394 } 402 }
395 403
396 } // namespace chrome 404 } // namespace chrome
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698