Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc

Issue 2079233004: Add the Windows.IsPinnedToTaskbar metric. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Grt's comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.h" 5 #include "chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 #endif 45 #endif
46 #endif // defined(OS_LINUX) && !defined(OS_CHROMEOS) 46 #endif // defined(OS_LINUX) && !defined(OS_CHROMEOS)
47 47
48 #if defined(USE_OZONE) || defined(USE_X11) 48 #if defined(USE_OZONE) || defined(USE_X11)
49 #include "ui/events/devices/input_device_event_observer.h" 49 #include "ui/events/devices/input_device_event_observer.h"
50 #include "ui/events/devices/input_device_manager.h" 50 #include "ui/events/devices/input_device_manager.h"
51 #endif // defined(USE_OZONE) || defined(USE_X11) 51 #endif // defined(USE_OZONE) || defined(USE_X11)
52 52
53 #if defined(OS_WIN) 53 #if defined(OS_WIN)
54 #include "base/win/windows_version.h" 54 #include "base/win/windows_version.h"
55 #include "chrome/browser/shell_integration_win.h"
55 #include "chrome/installer/util/google_update_settings.h" 56 #include "chrome/installer/util/google_update_settings.h"
56 #endif // defined(OS_WIN) 57 #endif // defined(OS_WIN)
57 58
58 namespace { 59 namespace {
59 60
60 enum UMALinuxGlibcVersion { 61 enum UMALinuxGlibcVersion {
61 UMA_LINUX_GLIBC_NOT_PARSEABLE, 62 UMA_LINUX_GLIBC_NOT_PARSEABLE,
62 UMA_LINUX_GLIBC_UNKNOWN, 63 UMA_LINUX_GLIBC_UNKNOWN,
63 UMA_LINUX_GLIBC_2_11, 64 UMA_LINUX_GLIBC_2_11,
64 // To log newer versions, just update tools/metrics/histograms/histograms.xml. 65 // To log newer versions, just update tools/metrics/histograms/histograms.xml.
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 GoogleUpdateSettings::RecordChromeUpdatePolicyHistograms(); 144 GoogleUpdateSettings::RecordChromeUpdatePolicyHistograms();
144 145
145 const base::win::OSInfo& os_info = *base::win::OSInfo::GetInstance(); 146 const base::win::OSInfo& os_info = *base::win::OSInfo::GetInstance();
146 UMA_HISTOGRAM_ENUMERATION("Windows.GetVersionExVersion", os_info.version(), 147 UMA_HISTOGRAM_ENUMERATION("Windows.GetVersionExVersion", os_info.version(),
147 base::win::VERSION_WIN_LAST); 148 base::win::VERSION_WIN_LAST);
148 UMA_HISTOGRAM_ENUMERATION("Windows.Kernel32Version", 149 UMA_HISTOGRAM_ENUMERATION("Windows.Kernel32Version",
149 os_info.Kernel32Version(), 150 os_info.Kernel32Version(),
150 base::win::VERSION_WIN_LAST); 151 base::win::VERSION_WIN_LAST);
151 UMA_HISTOGRAM_BOOLEAN("Windows.InCompatibilityMode", 152 UMA_HISTOGRAM_BOOLEAN("Windows.InCompatibilityMode",
152 os_info.version() != os_info.Kernel32Version()); 153 os_info.version() != os_info.Kernel32Version());
154 shell_integration::win::RecordIsPinnedToTaskbarHistogram();
gab 2016/06/28 20:59:18 Feels overkill to bounce to the BlockingPool only
Patrick Monette 2016/06/28 23:22:24 Done.
153 #endif // defined(OS_WIN) 155 #endif // defined(OS_WIN)
154 156
155 #if defined(OS_MACOSX) 157 #if defined(OS_MACOSX)
156 bluetooth_utility::BluetoothAvailability availability = 158 bluetooth_utility::BluetoothAvailability availability =
157 bluetooth_utility::GetBluetoothAvailability(); 159 bluetooth_utility::GetBluetoothAvailability();
158 UMA_HISTOGRAM_ENUMERATION("OSX.BluetoothAvailability", 160 UMA_HISTOGRAM_ENUMERATION("OSX.BluetoothAvailability",
159 availability, 161 availability,
160 bluetooth_utility::BLUETOOTH_AVAILABILITY_COUNT); 162 bluetooth_utility::BLUETOOTH_AVAILABILITY_COUNT);
161 #endif // defined(OS_MACOSX) 163 #endif // defined(OS_MACOSX)
162 164
(...skipping 224 matching lines...) Expand 10 before | Expand all | Expand 10 after
387 } 389 }
388 } 390 }
389 391
390 namespace chrome { 392 namespace chrome {
391 393
392 void AddMetricsExtraParts(ChromeBrowserMainParts* main_parts) { 394 void AddMetricsExtraParts(ChromeBrowserMainParts* main_parts) {
393 main_parts->AddParts(new ChromeBrowserMainExtraPartsMetrics()); 395 main_parts->AddParts(new ChromeBrowserMainExtraPartsMetrics());
394 } 396 }
395 397
396 } // namespace chrome 398 } // namespace chrome
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698