Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 2079233002: Fix a wrong test landed in r400392. (Closed)

Created:
4 years, 6 months ago by tkent
Modified:
4 years, 6 months ago
Reviewers:
keishi
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a wrong test landed in r400392. We need to clear |selected| state on every test run because every OPTION is selected after removeChild(). This CL makes select-single-remove.html very slower. BUG=620142 TBR=keishi@chromium.org Committed: https://crrev.com/49796c5e364e736e2ae3b8a12660b136b1135c9f Cr-Commit-Position: refs/heads/master@{#400639}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/PerformanceTests/DOM/select-single-remove.html View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
tkent
4 years, 6 months ago (2016-06-20 07:57:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2079233002/1
4 years, 6 months ago (2016-06-20 07:57:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 09:09:45 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 09:14:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/49796c5e364e736e2ae3b8a12660b136b1135c9f
Cr-Commit-Position: refs/heads/master@{#400639}

Powered by Google App Engine
This is Rietveld 408576698