Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Issue 2079203002: Convert video-dom* tests to testharness.js. (Closed)

Created:
4 years, 6 months ago by Srirama
Modified:
4 years, 6 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert video-dom* tests to testharness.js. Cleaning up video-dom* tests in media/track to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/b8425e4d5f1fb3237de1ca382cef56e67410f1ba Cr-Commit-Position: refs/heads/master@{#400657}

Patch Set 1 : #

Total comments: 10

Patch Set 2 : address nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -166 lines) Patch
M third_party/WebKit/LayoutTests/media/video-dom-autoplay.html View 1 chunk +17 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-dom-autoplay-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/video-dom-preload.html View 1 1 chunk +47 lines, -68 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-dom-preload-expected.txt View 1 chunk +0 lines, -58 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/video-dom-src.html View 1 chunk +16 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-dom-src-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
Srirama
PTAL
4 years, 6 months ago (2016-06-19 14:04:31 UTC) #5
fs
LGTM w/ nits https://codereview.chromium.org/2079203002/diff/40001/third_party/WebKit/LayoutTests/media/video-dom-preload.html File third_party/WebKit/LayoutTests/media/video-dom-preload.html (right): https://codereview.chromium.org/2079203002/diff/40001/third_party/WebKit/LayoutTests/media/video-dom-preload.html#newcode23 third_party/WebKit/LayoutTests/media/video-dom-preload.html:23: // Set via DOM s/DOM/IDL attribute/ ...
4 years, 6 months ago (2016-06-19 17:53:01 UTC) #6
Srirama
https://codereview.chromium.org/2079203002/diff/40001/third_party/WebKit/LayoutTests/media/video-dom-preload.html File third_party/WebKit/LayoutTests/media/video-dom-preload.html (right): https://codereview.chromium.org/2079203002/diff/40001/third_party/WebKit/LayoutTests/media/video-dom-preload.html#newcode23 third_party/WebKit/LayoutTests/media/video-dom-preload.html:23: // Set via DOM On 2016/06/19 17:53:01, fs wrote: ...
4 years, 6 months ago (2016-06-20 05:31:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2079203002/60001
4 years, 6 months ago (2016-06-20 05:31:55 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/241485)
4 years, 6 months ago (2016-06-20 07:49:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2079203002/60001
4 years, 6 months ago (2016-06-20 12:09:39 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 6 months ago (2016-06-20 12:13:29 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 12:15:52 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b8425e4d5f1fb3237de1ca382cef56e67410f1ba
Cr-Commit-Position: refs/heads/master@{#400657}

Powered by Google App Engine
This is Rietveld 408576698