|
|
Created:
4 years, 6 months ago by Dirk Pranke Modified:
4 years, 6 months ago CC:
chromium-reviews, ynovikov Base URL:
https://chromium.googlesource.com/chromium/src.git@rollup Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSync up mb_config.pyl w/ buildbot masters.
This CL removes a bunch of builders that no longer exist and
adds a few that didn't have configs yet.
TBR=thakis@chromium.org
BUG=
Committed: https://crrev.com/99b137c359588ef2c9a96c52a448b3a938e0847c
Cr-Commit-Position: refs/heads/master@{#400711}
Patch Set 1 #Patch Set 2 : merge #Patch Set 3 : put symbolized mixin back in #
Total comments: 5
Messages
Total messages: 26 (10 generated)
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2079173002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...) ios-simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by dpranke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2079173002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2079173002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Patchset #3 (id:40001) has been deleted
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2079173002/60001
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Sync up mb_config.pyl w/ buildbot masters. This CL removes a bunch of builders that no longer exist and adds a few that didn't have configs yet. TBR=thakis@chromium.org BUG= ========== to ========== Sync up mb_config.pyl w/ buildbot masters. This CL removes a bunch of builders that no longer exist and adds a few that didn't have configs yet. TBR=thakis@chromium.org BUG= Committed: https://crrev.com/99b137c359588ef2c9a96c52a448b3a938e0847c Cr-Commit-Position: refs/heads/master@{#400711} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/99b137c359588ef2c9a96c52a448b3a938e0847c Cr-Commit-Position: refs/heads/master@{#400711}
Message was sent while issue was closed.
thakis@chromium.org changed reviewers: + jmadill@chromium.org, kbr@chromium.org
Message was sent while issue was closed.
lgtm, but one remark below, and punting the new gpu bot config to jmadill/kbr https://codereview.chromium.org/2079173002/diff/60001/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2079173002/diff/60001/tools/mb/mb_config.pyl#... tools/mb/mb_config.pyl:733: 'linux_chromium_blimp_variable': 'findit', i don't know what the _variable bots do. i thought 'findit' is some java static analysis thing, so this line looks wrong from a distance. https://codereview.chromium.org/2079173002/diff/60001/tools/mb/mb_config.pyl#... tools/mb/mb_config.pyl:1612: 'swarming', 'gpu_tests', 'internal_gles2_conform_tests', 'gn', jmadill / kbr: Does this bot look right?
Message was sent while issue was closed.
https://codereview.chromium.org/2079173002/diff/60001/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2079173002/diff/60001/tools/mb/mb_config.pyl#... tools/mb/mb_config.pyl:1612: 'swarming', 'gpu_tests', 'internal_gles2_conform_tests', 'gn', On 2016/06/21 18:39:29, Nico wrote: > jmadill / kbr: Does this bot look right? Actually, I'm not sure it is -- not sure this should be specifying angle_deqp_tests, at least not yet. +ynovikov
Message was sent while issue was closed.
https://codereview.chromium.org/2079173002/diff/60001/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2079173002/diff/60001/tools/mb/mb_config.pyl#... tools/mb/mb_config.pyl:1612: 'swarming', 'gpu_tests', 'internal_gles2_conform_tests', 'gn', On 2016/06/21 18:54:13, Ken Russell OOO till 6-21-2016 wrote: > On 2016/06/21 18:39:29, Nico wrote: > > jmadill / kbr: Does this bot look right? > > Actually, I'm not sure it is -- not sure this should be specifying > angle_deqp_tests, at least not yet. +ynovikov I doubt the deqp tests compile at this time, so probably should be left out. Also same goes for gles2_conform_test, I don't see that config being enabled currently for the android bot I checked.
Message was sent while issue was closed.
On 2016/06/21 19:24:30, Jamie Madill wrote: > https://codereview.chromium.org/2079173002/diff/60001/tools/mb/mb_config.pyl > File tools/mb/mb_config.pyl (right): > > https://codereview.chromium.org/2079173002/diff/60001/tools/mb/mb_config.pyl#... > tools/mb/mb_config.pyl:1612: 'swarming', 'gpu_tests', > 'internal_gles2_conform_tests', 'gn', > On 2016/06/21 18:54:13, Ken Russell OOO till 6-21-2016 wrote: > > On 2016/06/21 18:39:29, Nico wrote: > > > jmadill / kbr: Does this bot look right? > > > > Actually, I'm not sure it is -- not sure this should be specifying > > angle_deqp_tests, at least not yet. +ynovikov > > I doubt the deqp tests compile at this time, so probably should be left out. > Also same goes for gles2_conform_test, I don't see that config being enabled > currently for the android bot I checked. Okay. I was guessing randomly, seeing as how that builder hasn't done any builds. Will fix.
Message was sent while issue was closed.
https://codereview.chromium.org/2079173002/diff/60001/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2079173002/diff/60001/tools/mb/mb_config.pyl#... tools/mb/mb_config.pyl:733: 'linux_chromium_blimp_variable': 'findit', On 2016/06/21 18:39:29, Nico wrote: > i don't know what the _variable bots do. i thought 'findit' is some java static > analysis thing, so this line looks wrong from a distance. Findit in this case is the system the QA team runs to auto-bisect and find regressions. The "variable" builders mirror continuous builders and bisect things, hence what they run is "variable".
Message was sent while issue was closed.
Fix posted to https://codereview.chromium.org/2083163002/ . |