chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js - Issue 2079073002: Make ChromeVox Next a setting in options page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js

Issue 2079073002: Make ChromeVox Next a setting in options page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: m Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js ('K') | « chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js ('k') | chrome/browser/resources/chromeos/chromevox/cvox2/background/notifications.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js

index d5da5072a72ead8998c936abee769ddb2527936f..cc155b77ca170cfd9950f5dcd6088362d733e844 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js

@@ -98,13 +98,6 @@ DesktopAutomationHandler.prototype = {

ChromeVoxState.instance.setCurrentRange(cursors.Range.fromNode(node));

- // Check to see if we've crossed roots. Continue if we've crossed roots or

- // are not within web content.

- if (node.root.role == RoleType.desktop ||

- !prevRange ||

- prevRange.start.node.root != node.root)

- ChromeVoxState.instance.refreshMode(node.root);

// Don't process nodes inside of web content if ChromeVox Next is inactive.

if (node.root.role != RoleType.desktop &&

ChromeVoxState.instance.mode === ChromeVoxMode.CLASSIC) {

@@ -232,8 +225,6 @@ DesktopAutomationHandler.prototype = {

* @param {!AutomationEvent} evt

onLoadComplete: function(evt) {

- ChromeVoxState.instance.refreshMode(evt.target);

// Don't process nodes inside of web content if ChromeVox Next is inactive.

if (evt.target.root.role != RoleType.desktop &&

ChromeVoxState.instance.mode === ChromeVoxMode.CLASSIC)