chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js - Issue 2079073002: Make ChromeVox Next a setting in options page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js

Issue 2079073002: Make ChromeVox Next a setting in options page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: m Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/chromevox/background/prefs.js ('k') | chrome/browser/resources/chromeos/chromevox/common/command_store.js » ('j') | chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js

diff --git a/chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js b/chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js

index d084d5bc12fd3209d86ab37eff77dfc7d0a55659..aee34958b368db3f9e76daaa3813df7932ec342e 100644

--- a/chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js

+++ b/chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js

@@ -226,7 +226,7 @@ cvox.TabsApiHandler.prototype = {

if (!tab)

return;

- global.backgroundObj.refreshMode(tab);

+ global.backgroundObj.setCurrentRange(cursors.Range.fromNode(tab));

dmazzoni 2016/06/21 21:21:02 What breaks if we just delete this? Shouldn't we b

David Tseng 2016/06/21 22:41:32 Pages that don't fire load completes reliably (tha

});