Make ChromeVox Next a setting in options page.

Make ChromeVox Next a setting in options page.

- persists the ChromeVox mode in local storage; this makes it so that you can start using ChromeVox Next right way on startup
- makes the new ChromeVox experience a checkbox in options; rework some of the mode setting logic to make this happen.
- add strings for announcing switches between the new and classic experiences; also, fire a message center notification if switching to the new experience for the first time.

This change required some non-trivial amount of refactoring:
- use ChromeVoxState.instance.getCurrentRange() as the definitive notion of mode; mode is based on current range.
- ChromeVoxState and global were both "global" objects; merge them into ChromeVoxState
- removed and simplified various mode related logic
- Background (the ChromeVox Next background page) now explicitly depends on ChromeVoxBackground (ChromeVox classic background page) via goog.require. This was necessary to ensure that the window.prefs object was created already for keyboard map switching on startup

BUG=618094, 618092, 618090
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e771bbe3e029830c01fb85d50a9be5559dc7aac4
Cr-Commit-Position: refs/heads/master@{#401596}

[David Tseng, 2016-06-17 20:31:17]

Description was changed from

==========
Make ChromeVox Next a setting in options page.
==========

to

==========
Make ChromeVox Next a setting in options page.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-06-17 20:33:39]

Description was changed from

==========
Make ChromeVox Next a setting in options page.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Make ChromeVox Next a setting in options page.

- persists the ChromeVox mode in local storage
- makes the new ChromeVox experience a checkbox in options; rework some of the
mode setting logic to make this happen.
- add strings for announcing switches between the new and classic experiences;
also, fire a message center notification if switching to the new experience for
the first time.

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-06-17 20:33:39]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[David Tseng, 2016-06-17 20:40:31]

Ready for a look. Note that the offline discussion about disabling all classic
pages becomes more visible with this change. By checking the new option off (to
Classic), and closing the window, we end up on a page where classic is not
re-injected. The current logic only re-injects in the active tab; we're still
not covering all cases I suspect. I didn't try to fix it in this cl because I
know you're looking at that case in your meta tag cl.

[dmazzoni, 2016-06-20 19:49:03]

https://codereview.chromium.org/2079073002/diff/1/chrome/browser/resources/ch...
File
chrome/browser/resources/chromeos/chromevox/chromevox/background/options.html
(right):

https://codereview.chromium.org/2079073002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/chromevox/background/options.html:68:
Use the new ChromeVox experience (beta)
This should maybe say ChromeVox Next since we're calling it that in the
chromevox.com docs

https://codereview.chromium.org/2079073002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/chromevox/common/command_store.js
(right):

https://codereview.chromium.org/2079073002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/common/command_store.js:160:
announce: false, 'category': 'help_commands'},
int: indendation

https://codereview.chromium.org/2079073002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
(right):

https://codereview.chromium.org/2079073002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:220:
localStorage['mode'] = mode;
Do you want to be setting the mode to things like 'compat'?
It might be harmless, but it's not clear it has any value.

https://codereview.chromium.org/2079073002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:312:
toggleMode: function(opt_setValue) {
maybe this should be toggleNext since there are four possible modes but this
just takes two values

https://codereview.chromium.org/2079073002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:318:
return ChromeVoxMode.CLASSIC;
indentation

https://codereview.chromium.org/2079073002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:339:
this.setMode(newMode, true);
Can you just call refreshMode() here?

It seems like more of this could be refactored to share logic
between refreshMode and toggle.

https://codereview.chromium.org/2079073002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js
(right):

https://codereview.chromium.org/2079073002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js:317:
return this.node != null;
Why this change? Did you not want to check the root?

[David Tseng, 2016-06-20 22:31:08]

https://codereview.chromium.org/2079073002/diff/1/chrome/browser/resources/ch...
File
chrome/browser/resources/chromeos/chromevox/chromevox/background/options.html
(right):

https://codereview.chromium.org/2079073002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/chromevox/background/options.html:68:
Use the new ChromeVox experience (beta)
On 2016/06/20 19:49:03, dmazzoni wrote:
> This should maybe say ChromeVox Next since we're calling it that in the
> http://chromevox.com docs

Done.

https://codereview.chromium.org/2079073002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/chromevox/common/command_store.js
(right):

https://codereview.chromium.org/2079073002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/common/command_store.js:160:
announce: false, 'category': 'help_commands'},
On 2016/06/20 19:49:03, dmazzoni wrote:
> int: indendation

Done.

https://codereview.chromium.org/2079073002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
(right):

https://codereview.chromium.org/2079073002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:220:
localStorage['mode'] = mode;
On 2016/06/20 19:49:03, dmazzoni wrote:
> Do you want to be setting the mode to things like 'compat'?
> It might be harmless, but it's not clear it has any value.

Now only storing the "nextness" state.

https://codereview.chromium.org/2079073002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:312:
toggleMode: function(opt_setValue) {
On 2016/06/20 19:49:03, dmazzoni wrote:
> maybe this should be toggleNext since there are four possible modes but this
> just takes two values

Done.

https://codereview.chromium.org/2079073002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:318:
return ChromeVoxMode.CLASSIC;
On 2016/06/20 19:49:03, dmazzoni wrote:
> indentation

Done.

https://codereview.chromium.org/2079073002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:339:
this.setMode(newMode, true);
On 2016/06/20 19:49:03, dmazzoni wrote:
> Can you just call refreshMode() here?
> 
> It seems like more of this could be refactored to share logic
> between refreshMode and toggle.
> 

RefreshMode differs in the mode transitions it allows. In particular, you cannot
go from force next back to classic/compat. For example, on a load complete, even
though chrome://downloads is whitelisted for compat, force next mode stays
enabled. So, you'd have to call setMode for that case at least.

https://codereview.chromium.org/2079073002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js
(right):

https://codereview.chromium.org/2079073002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js:317:
return this.node != null;
On 2016/06/20 19:49:03, dmazzoni wrote:
> Why this change? Did you not want to check the root?

Your node recovery getter now does that.

[dmazzoni, 2016-06-20 22:41:44]

https://codereview.chromium.org/2079073002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
(right):

https://codereview.chromium.org/2079073002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:339:
this.setMode(newMode, true);
On 2016/06/20 22:31:08, David Tseng wrote:
> On 2016/06/20 19:49:03, dmazzoni wrote:
> > Can you just call refreshMode() here?
> > 
> > It seems like more of this could be refactored to share logic
> > between refreshMode and toggle.
> > 
> 
> RefreshMode differs in the mode transitions it allows. In particular, you
cannot
> go from force next back to classic/compat. For example, on a load complete,
even
> though chrome://downloads is whitelisted for compat, force next mode stays
> enabled. So, you'd have to call setMode for that case at least.

Why not just refreshMode to handle all of those cases, though?

Something like:

constructor:
  refreshMode();

toggleMode:
  var oldMode = this.mode_;
  localStorage['force_next'] = newForceNext;
  refreshMode();
  if (this.mode_ != oldMode) {
    cvox.ChromeVox.tts.speak(announce, ...);
  }

refreshMode:
  if (localStorage['force_next']) {
  } else ...

[David Tseng, 2016-06-20 23:39:23]

On Mon, Jun 20, 2016 at 3:41 PM, <dmazzoni@chromium.org> wrote:

>
> https://codereview.chromium.org/2079073002/diff/1/chrome/bro
> wser/resources/chromeos/chromevox/cvox2/background/background.js
> File
> chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
> (right):
>
> https://codereview.chromium.org/2079073002/diff/1/chrome/bro
> wser/resources/chromeos/chromevox/cvox2/background/backgroun
> d.js#newcode339
> chrome/browser/resources/chromeos/chromevox/cvox2/background
> /background.js:339:
> this.setMode(newMode, true);
> On 2016/06/20 22:31:08, David Tseng wrote:
> > On 2016/06/20 19:49:03, dmazzoni wrote:
> > > Can you just call refreshMode() here?
> > >
> > > It seems like more of this could be refactored to share logic
> > > between refreshMode and toggle.
> > >
> >
> > RefreshMode differs in the mode transitions it allows. In particular,
> you cannot
> > go from force next back to classic/compat. For example, on a load
> complete, even
> > though chrome://downloads is whitelisted for compat, force next mode
> stays
> > enabled. So, you'd have to call setMode for that case at least.
>
> Why not just refreshMode to handle all of those cases, though?
>
> Because refreshMode and toggleNext handle different cases and have
different method signatures.
I could create another method to collect code that they do share if you
really like.

Something like:
>
> constructor:
> refreshMode();
>
> toggleMode:
> var oldMode = this.mode_;
> localStorage['force_next'] = newForceNext;
> refreshMode();
> if (this.mode_ != oldMode) {
> cvox.ChromeVox.tts.speak(announce, ...);
> }
>
> refreshMode:
> if (localStorage['force_next']) {
> } else ...
>
> I'm not clear on the above snippet. toggleNext handles switching between
force next and classic/compat. refreshMode switches among next, classic,
and compat; force next overrides everything.





> https://codereview.chromium.org/2079073002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dmazzoni, 2016-06-21 00:10:40]

Here's what I had in mind:

Get rid of setMode(), make everything a call to refreshMode().

Create a new boolean temporaryForceNext_ or something like that to complement
the localStorage forceNext.

Oh! And when doing the permanent toggle it should set the temporary toggle off.
Otherwise you could Cvox+Q+Q, then toggle Cvox Next on in the options, then
toggle it off in the options but it'd still be on, which seems confusing.

Either way, I think the new mode should always be possible to compute based on
these settings, and the current node.

That way any time something happens that might result in a mode change, we just
call refreshMode(), which is now the only place allowed to call setMode(). Then
refreshMode() is the only place we need to audit and it should be much more
clear.

[David Tseng, 2016-06-21 19:35:04]

On 2016/06/21 00:10:40, dmazzoni wrote:
> Here's what I had in mind:
> 
> Get rid of setMode(), make everything a call to refreshMode().
> 
> Create a new boolean temporaryForceNext_ or something like that to complement
> the localStorage forceNext.
> 
> Oh! And when doing the permanent toggle it should set the temporary toggle
off.
> Otherwise you could Cvox+Q+Q, then toggle Cvox Next on in the options, then
> toggle it off in the options but it'd still be on, which seems confusing.
> 
> Either way, I think the new mode should always be possible to compute based on
> these settings, and the current node.
> 
> That way any time something happens that might result in a mode change, we
just
> call refreshMode(), which is now the only place allowed to call setMode().
Then
> refreshMode() is the only place we need to audit and it should be much more
> clear.

PTAL. Computing on demand mode now.

[dmazzoni, 2016-06-21 21:21:02]

lgtm

Thanks, this is basically fine now, just a few more
suggestions.

https://codereview.chromium.org/2079073002/diff/40001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js
(right):

https://codereview.chromium.org/2079073002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js:229:
global.backgroundObj.setCurrentRange(cursors.Range.fromNode(tab));
What breaks if we just delete this? Shouldn't we be getting an
actual focus event?

https://codereview.chromium.org/2079073002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
(right):

https://codereview.chromium.org/2079073002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:138:
this.mode_ = ChromeVoxMode.COMPAT;
Can you use getMode() here?

https://codereview.chromium.org/2079073002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:150:
this.onModeChanged_(ChromeVoxMode.COMPAT, ChromeVoxMode.CLASSIC);
It'd be nice if you could just call refreshMode() here and have it compute the
new mode and call onModeChanged automatically based on that - see comment below

https://codereview.chromium.org/2079073002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:221:
return ChromeVoxMode.COMPAT;
nit: wrong indent

https://codereview.chromium.org/2079073002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:353:
var oldMode = this.mode_;
Could these 5 lines be refreshMode()?

Then any call to forceChromeVoxNextActive can be replaced with refreshMode().

https://codereview.chromium.org/2079073002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:379:
forceChromeVoxNextActive: function() {
This doesn't actually force it active, it assumes that localStorage and mode_
have already been set.

[David Tseng, 2016-06-21 22:41:32]

PTAL.

Since you had several comments, I'll wait for you to take another pass.

https://codereview.chromium.org/2079073002/diff/40001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js
(right):

https://codereview.chromium.org/2079073002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js:229:
global.backgroundObj.setCurrentRange(cursors.Range.fromNode(tab));
On 2016/06/21 21:21:02, dmazzoni wrote:
> What breaks if we just delete this? Shouldn't we be getting an
> actual focus event?

Pages that don't fire load completes reliably (that's why the loading earcon had
problems stopping).

https://codereview.chromium.org/2079073002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
(right):

https://codereview.chromium.org/2079073002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:138:
this.mode_ = ChromeVoxMode.COMPAT;
On 2016/06/21 21:21:02, dmazzoni wrote:
> Can you use getMode() here?

No, because we always need to perform the basic setup required of a mode
transition on startup especially if we're in force next or compat mode.

I made this nullable and set it to null.

https://codereview.chromium.org/2079073002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:150:
this.onModeChanged_(ChromeVoxMode.COMPAT, ChromeVoxMode.CLASSIC);
On 2016/06/21 21:21:02, dmazzoni wrote:
> It'd be nice if you could just call refreshMode() here and have it compute the
 new mode and call onModeChanged automatically based on that - see comment below

But, that's doing basically the equivalent. You're just hiding the transition
occuring.
this.mode_ initially gets set to ChromeVoxMode.COMPAT, so if you're unlucky,
you'll transition from compat to compat and not add any listeners.

The right way to think about this I think is setting the range which then
determines the mode (transitions if needed). classic -> force next means setting
the range to the focused node. Moving from force next to classic means setting
the current range to null.

https://codereview.chromium.org/2079073002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:221:
return ChromeVoxMode.COMPAT;
On 2016/06/21 21:21:02, dmazzoni wrote:
> nit: wrong indent

Done.

https://codereview.chromium.org/2079073002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:353:
var oldMode = this.mode_;
On 2016/06/21 21:21:02, dmazzoni wrote:
> Could these 5 lines be refreshMode()?
> 
> Then any call to forceChromeVoxNextActive can be replaced with refreshMode().
> 

I'd like to limit the number of methods exposed by background especially if
there are no callers.

It's also not clear from this block that force next would go through the right
transitions since this.mode_ might have been set to force next already (e.g. on
startup) since it's getting persisted.

https://codereview.chromium.org/2079073002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:379:
forceChromeVoxNextActive: function() {
On 2016/06/21 21:21:02, dmazzoni wrote:
> This doesn't actually force it active, it assumes that localStorage and mode_
> have already been set.

Yup; removed and in-lined since there are no external callers anyway.

[dmazzoni, 2016-06-22 05:23:33]

lgtm

Looks great, setCurrentRangeToFocus is much more clear and
I like how setting the range is now essentially the only trigger of
a mode change. Much simpler.

https://codereview.chromium.org/2079073002/diff/100001/chrome/browser/resourc...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
(right):

https://codereview.chromium.org/2079073002/diff/100001/chrome/browser/resourc...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:140:
if (localStorage['useNext'] == 'true')
nit: maybe a blank line before this to better associate the jsdoc with
this.mode_.

https://codereview.chromium.org/2079073002/diff/100001/chrome/browser/resourc...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:233:
* @param {?ChromeVoxMode} oldMode
Docstring for this maybe saying it can be null to force a transition or
initialization of newMode

[David Tseng, 2016-06-22 21:08:06]

Description was changed from

==========
Make ChromeVox Next a setting in options page.

- persists the ChromeVox mode in local storage
- makes the new ChromeVox experience a checkbox in options; rework some of the
mode setting logic to make this happen.
- add strings for announcing switches between the new and classic experiences;
also, fire a message center notification if switching to the new experience for
the first time.

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Make ChromeVox Next a setting in options page.

- persists the ChromeVox mode in local storage; this makes it so that you can
start using ChromeVox Next right way on startup
- makes the new ChromeVox experience a checkbox in options; rework some of the
mode setting logic to make this happen.
- add strings for announcing switches between the new and classic experiences;
also, fire a message center notification if switching to the new experience for
the first time.

This change required some non-trivial amount of refactoring:
- use ChromeVoxState.instance.getCurrentRange() as the definitive notion of
mode; mode is based on current range.
- ChromeVoxState and global were both "global" objects; merge them into
ChromeVoxState
- removed and simplified various mode related logic
- Background (the ChromeVox Next background page) now explicitly depends on
ChromeVoxBackground (ChromeVox classic background page) via goog.require. This
was necessary to ensure that the window.prefs object was created already for
keyboard map switching on startup

BUG=618094,618092,618090
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-06-23 13:23:37]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-06-23 13:23:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2079073002/#ps200001
(title: "m")

[commit-bot: I haz the power, 2016-06-23 13:23:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2079073002/200001

[commit-bot: I haz the power, 2016-06-23 13:37:29]

Description was changed from

==========
Make ChromeVox Next a setting in options page.

- persists the ChromeVox mode in local storage; this makes it so that you can
start using ChromeVox Next right way on startup
- makes the new ChromeVox experience a checkbox in options; rework some of the
mode setting logic to make this happen.
- add strings for announcing switches between the new and classic experiences;
also, fire a message center notification if switching to the new experience for
the first time.

This change required some non-trivial amount of refactoring:
- use ChromeVoxState.instance.getCurrentRange() as the definitive notion of
mode; mode is based on current range.
- ChromeVoxState and global were both "global" objects; merge them into
ChromeVoxState
- removed and simplified various mode related logic
- Background (the ChromeVox Next background page) now explicitly depends on
ChromeVoxBackground (ChromeVox classic background page) via goog.require. This
was necessary to ensure that the window.prefs object was created already for
keyboard map switching on startup

BUG=618094,618092,618090
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Make ChromeVox Next a setting in options page.

- persists the ChromeVox mode in local storage; this makes it so that you can
start using ChromeVox Next right way on startup
- makes the new ChromeVox experience a checkbox in options; rework some of the
mode setting logic to make this happen.
- add strings for announcing switches between the new and classic experiences;
also, fire a message center notification if switching to the new experience for
the first time.

This change required some non-trivial amount of refactoring:
- use ChromeVoxState.instance.getCurrentRange() as the definitive notion of
mode; mode is based on current range.
- ChromeVoxState and global were both "global" objects; merge them into
ChromeVoxState
- removed and simplified various mode related logic
- Background (the ChromeVox Next background page) now explicitly depends on
ChromeVoxBackground (ChromeVox classic background page) via goog.require. This
was necessary to ensure that the window.prefs object was created already for
keyboard map switching on startup

BUG=618094,618092,618090
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-06-23 13:37:30]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-06-23 13:39:16]

Description was changed from

==========
Make ChromeVox Next a setting in options page.

- persists the ChromeVox mode in local storage; this makes it so that you can
start using ChromeVox Next right way on startup
- makes the new ChromeVox experience a checkbox in options; rework some of the
mode setting logic to make this happen.
- add strings for announcing switches between the new and classic experiences;
also, fire a message center notification if switching to the new experience for
the first time.

This change required some non-trivial amount of refactoring:
- use ChromeVoxState.instance.getCurrentRange() as the definitive notion of
mode; mode is based on current range.
- ChromeVoxState and global were both "global" objects; merge them into
ChromeVoxState
- removed and simplified various mode related logic
- Background (the ChromeVox Next background page) now explicitly depends on
ChromeVoxBackground (ChromeVox classic background page) via goog.require. This
was necessary to ensure that the window.prefs object was created already for
keyboard map switching on startup

BUG=618094,618092,618090
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Make ChromeVox Next a setting in options page.

- persists the ChromeVox mode in local storage; this makes it so that you can
start using ChromeVox Next right way on startup
- makes the new ChromeVox experience a checkbox in options; rework some of the
mode setting logic to make this happen.
- add strings for announcing switches between the new and classic experiences;
also, fire a message center notification if switching to the new experience for
the first time.

This change required some non-trivial amount of refactoring:
- use ChromeVoxState.instance.getCurrentRange() as the definitive notion of
mode; mode is based on current range.
- ChromeVoxState and global were both "global" objects; merge them into
ChromeVoxState
- removed and simplified various mode related logic
- Background (the ChromeVox Next background page) now explicitly depends on
ChromeVoxBackground (ChromeVox classic background page) via goog.require. This
was necessary to ensure that the window.prefs object was created already for
keyboard map switching on startup

BUG=618094,618092,618090
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e771bbe3e029830c01fb85d50a9be5559dc7aac4
Cr-Commit-Position: refs/heads/master@{#401596}
==========

[commit-bot: I haz the power, 2016-06-23 13:39:18]

Patchset 11 (id:??) landed as
https://crrev.com/e771bbe3e029830c01fb85d50a9be5559dc7aac4
Cr-Commit-Position: refs/heads/master@{#401596}

[flackr, 2016-06-23 14:28:43]

A revert of this CL (patchset #11 id:200001) has been created in
https://codereview.chromium.org/2092743002/ by flackr@chromium.org.

The reason for reverting is: Failing BackgroundTest.DisappearingObject on
chromiumos:
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...

I verified locally that it seems to consistently time out with this patch..