Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2079023002: Revert of mac: ensure ui::Compositor exists for visible RWHVs (Closed)

Created:
4 years, 6 months ago by enne (OOO)
Modified:
4 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, nona+watch_chromium.org, shuchen+watch_chromium.org, James Su, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of mac: ensure ui::Compositor exists for visible RWHVs (patchset #14 id:260001 of https://codereview.chromium.org/2005013002/ ) Reason for revert: Causes windows to stay white if minimized for >5 min Original issue's description: > mac: ensure ui::Compositor exists for visible RWHVs > > RenderWidgetHostViewMac is careful about creating ui::Compositor and so > currently only does this in Show and SwapCompositorFrame. However, if > it the RenderWidgetHostView is created while the RenderWidgetHost is > visible, then Show will early out and never create a ui::Compositor. > > This causes problems with begin frame scheduling, which wants to have > the Display (which is created as part of creating the ui::Compositor's > output surface currently) own the real begin frame source that drives > everything. In that world, if no ui::Compositor exists, no frames ever > are sent or swapped. So, the ui::Compositor needs to be created first. > > Also, if the ui::Compositor is correctly created during Show (or the > constructor), then there's no need to ensure that it exists during > swap compositor frame, and so that can be safely removed. > > R=asvitkine@chromium.org,ccameron@chromium.org > > Committed: https://crrev.com/b08fb143ac17b3cc42def859e3b0a9c93bda06f3 > Cr-Commit-Position: refs/heads/master@{#400324} TBR=asvitkine@chromium.org,ccameron@chromium.org,danakj@chromium.org,phajdan.jr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/81122fabd6bb8f919414b7796d4668ec55eef877 Cr-Commit-Position: refs/heads/master@{#400446}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -58 lines) Patch
M content/browser/renderer_host/render_widget_host_view_mac.mm View 7 chunks +6 lines, -18 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm View 3 chunks +5 lines, -9 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M content/public/test/test_renderer_host.cc View 3 chunks +0 lines, -13 lines 0 comments Download
M content/test/BUILD.gn View 2 chunks +0 lines, -5 lines 0 comments Download
M ui/accelerated_widget_mac/window_resize_helper_mac.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/accelerated_widget_mac/window_resize_helper_mac.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
enne (OOO)
Created Revert of mac: ensure ui::Compositor exists for visible RWHVs
4 years, 6 months ago (2016-06-17 17:05:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2079023002/1
4 years, 6 months ago (2016-06-17 17:05:21 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-17 17:06:05 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 17:07:38 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/81122fabd6bb8f919414b7796d4668ec55eef877
Cr-Commit-Position: refs/heads/master@{#400446}

Powered by Google App Engine
This is Rietveld 408576698