DescriptionRevert of mac: ensure ui::Compositor exists for visible RWHVs (patchset #14 id:260001 of https://codereview.chromium.org/2005013002/ )
Reason for revert:
Causes windows to stay white if minimized for >5 min
Original issue's description:
> mac: ensure ui::Compositor exists for visible RWHVs
>
> RenderWidgetHostViewMac is careful about creating ui::Compositor and so
> currently only does this in Show and SwapCompositorFrame. However, if
> it the RenderWidgetHostView is created while the RenderWidgetHost is
> visible, then Show will early out and never create a ui::Compositor.
>
> This causes problems with begin frame scheduling, which wants to have
> the Display (which is created as part of creating the ui::Compositor's
> output surface currently) own the real begin frame source that drives
> everything. In that world, if no ui::Compositor exists, no frames ever
> are sent or swapped. So, the ui::Compositor needs to be created first.
>
> Also, if the ui::Compositor is correctly created during Show (or the
> constructor), then there's no need to ensure that it exists during
> swap compositor frame, and so that can be safely removed.
>
> R=asvitkine@chromium.org,ccameron@chromium.org
>
> Committed: https://crrev.com/b08fb143ac17b3cc42def859e3b0a9c93bda06f3
> Cr-Commit-Position: refs/heads/master@{#400324}
TBR=asvitkine@chromium.org,ccameron@chromium.org,danakj@chromium.org,phajdan.jr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Committed: https://crrev.com/81122fabd6bb8f919414b7796d4668ec55eef877
Cr-Commit-Position: refs/heads/master@{#400446}
Patch Set 1 #
Messages
Total messages: 6 (2 generated)
|