Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2079014: Log time in suspend. (Closed)

Created:
10 years, 7 months ago by petkov
Modified:
9 years, 7 months ago
Reviewers:
Sameer Nanda
CC:
chromium-os-reviews_chromium.org, davidjames, Sameer Nanda
Base URL:
ssh://git@chromiumos-git/chromeos
Visibility:
Public.

Description

Log time in suspend.

Patch Set 1 #

Patch Set 2 : And the send_metrics_on_resume script... #

Total comments: 2

Patch Set 3 : Address review comments. #

Patch Set 4 : Different histograms for resume and boot. #

Patch Set 5 : Simplify the option parsing code for now. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -1 line) Patch
M src/platform/acpi/action_lid.sh View 1 2 2 chunks +8 lines, -1 line 0 comments Download
M src/platform/init/dump-boot-stats.conf View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
A src/platform/power_manager/send_metrics_on_resume View 3 4 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
petkov
Not sure if I really need the || true or if it's OK for the ...
10 years, 7 months ago (2010-05-19 17:33:27 UTC) #1
petkov
Added the missing script.
10 years, 7 months ago (2010-05-19 17:36:03 UTC) #2
Sameer Nanda
http://codereview.chromium.org/2079014/diff/3001/4002 File src/platform/acpi/send_metrics_on_resume (right): http://codereview.chromium.org/2079014/diff/3001/4002#newcode17 src/platform/acpi/send_metrics_on_resume:17: TIME_IN_SUSPEND=$((($RESUME_AT - $SUSPEND_AT + 30) / 60)) can you ...
10 years, 7 months ago (2010-05-19 17:49:54 UTC) #3
petkov
PTAL http://codereview.chromium.org/2079014/diff/3001/4002 File src/platform/acpi/send_metrics_on_resume (right): http://codereview.chromium.org/2079014/diff/3001/4002#newcode17 src/platform/acpi/send_metrics_on_resume:17: TIME_IN_SUSPEND=$((($RESUME_AT - $SUSPEND_AT + 30) / 60)) On ...
10 years, 7 months ago (2010-05-19 18:12:47 UTC) #4
Sameer Nanda
LGTM
10 years, 7 months ago (2010-05-19 18:15:31 UTC) #5
petkov
PTAL -- updated with separate histograms for resume and boot, per our discussion.
10 years, 7 months ago (2010-05-19 19:36:25 UTC) #6
petkov
PTAL -- as discussed, tested on the netbook.
10 years, 7 months ago (2010-05-19 19:55:52 UTC) #7
Sameer Nanda
10 years, 7 months ago (2010-05-19 19:58:40 UTC) #8 
LGTM. Thanks!

Powered by Google App Engine
This is Rietveld 408576698