Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: pkg/analyzer/lib/source/embedder.dart

Issue 2078993002: Remove embedder locator from analysis context (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/test/context_manager_test.dart ('k') | pkg/analyzer/lib/src/context/context.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/source/embedder.dart
diff --git a/pkg/analyzer/lib/source/embedder.dart b/pkg/analyzer/lib/source/embedder.dart
index 2ad20d6613ae38364d8578b49149f2c550296538..56abc6a586c848014abadeae93ef46263b12962d 100644
--- a/pkg/analyzer/lib/source/embedder.dart
+++ b/pkg/analyzer/lib/source/embedder.dart
@@ -187,7 +187,7 @@ class EmbedderYamlLocator {
EmbedderYamlLocator(Map<String, List<Folder>> packageMap) {
if (packageMap != null) {
- refresh(packageMap);
+ _processPackageMap(packageMap);
}
}
@@ -199,10 +199,9 @@ class EmbedderYamlLocator {
void refresh(Map<String, List<Folder>> packageMap) {
// Clear existing.
embedderYamls.clear();
- if (packageMap == null) {
- return;
+ if (packageMap != null) {
+ _processPackageMap(packageMap);
}
- packageMap.forEach(_processPackage);
}
/// Given the yaml for an embedder ([embedderYaml]) and a folder
@@ -231,6 +230,10 @@ class EmbedderYamlLocator {
}
}
+ void _processPackageMap(Map<String, List<Folder>> packageMap) {
+ packageMap.forEach(_processPackage);
+ }
+
/// Read the contents of [libDir]/[EMBEDDER_FILE_NAME] as a string.
/// Returns null if the file doesn't exist.
String _readEmbedderYaml(Folder libDir) {
« no previous file with comments | « pkg/analysis_server/test/context_manager_test.dart ('k') | pkg/analyzer/lib/src/context/context.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698