Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: pkg/analysis_server/test/context_manager_test.dart

Issue 2078993002: Remove embedder locator from analysis context (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/context_manager.dart ('k') | pkg/analyzer/lib/source/embedder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/context_manager_test.dart
diff --git a/pkg/analysis_server/test/context_manager_test.dart b/pkg/analysis_server/test/context_manager_test.dart
index efcbcdd2f0a34c0553df3fd628815903a2b56532..b6643de59ce9cc576eb6b1a4231a20c4c274034b 100644
--- a/pkg/analysis_server/test/context_manager_test.dart
+++ b/pkg/analysis_server/test/context_manager_test.dart
@@ -2648,11 +2648,10 @@ class TestContextManagerCallbacks extends ContextManagerCallbacks {
currentContextFilePaths[path] = <String, int>{};
currentContextSources[path] = new HashSet<Source>();
currentContext = AnalysisEngine.instance.createAnalysisContext();
- _locateEmbedderYamls(currentContext, disposition);
List<UriResolver> resolvers = [];
if (currentContext is InternalAnalysisContext) {
EmbedderYamlLocator embedderYamlLocator =
- (currentContext as InternalAnalysisContext).embedderYamlLocator;
+ disposition.getEmbedderLocator(resourceProvider);
EmbedderSdk sdk = new EmbedderSdk(embedderYamlLocator.embedderYamls);
if (sdk.libraryMap.size() > 0) {
// We have some embedder dart: uri mappings, add the resolver
@@ -2734,19 +2733,6 @@ class TestContextManagerCallbacks extends ContextManagerCallbacks {
void updateContextPackageUriResolver(AnalysisContext context) {
// Nothing to do.
}
-
- /// If [disposition] has a package map, attempt to locate `_embedder.yaml`
- /// files.
- void _locateEmbedderYamls(
- InternalAnalysisContext context, FolderDisposition disposition) {
- Map<String, List<Folder>> packageMap;
- if (disposition is PackageMapDisposition) {
- packageMap = disposition.packageMap;
- } else if (disposition is PackagesFileDisposition) {
- packageMap = disposition.buildPackageMap(resourceProvider);
- }
- context.embedderYamlLocator.refresh(packageMap);
- }
}
/**
« no previous file with comments | « pkg/analysis_server/lib/src/context_manager.dart ('k') | pkg/analyzer/lib/source/embedder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698