Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 2078993002: Remove embedder locator from analysis context (Closed)

Created:
4 years, 6 months ago by Brian Wilkerson
Modified:
4 years, 6 months ago
Reviewers:
scheglov, pquitslund
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -91 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 3 chunks +3 lines, -16 lines 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 14 chunks +83 lines, -45 lines 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 2 chunks +1 line, -15 lines 0 comments Download
M pkg/analyzer/lib/source/embedder.dart View 3 chunks +7 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 2 chunks +5 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer_cli/lib/src/driver.dart View 2 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
This removes an order dependency in which we have to create a context before we ...
4 years, 6 months ago (2016-06-17 16:07:28 UTC) #2
scheglov
LGTM
4 years, 6 months ago (2016-06-17 16:10:15 UTC) #3
pquitslund
lgtm
4 years, 6 months ago (2016-06-17 16:33:37 UTC) #4
Brian Wilkerson
4 years, 6 months ago (2016-06-17 16:42:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5c97a88dddee8cf19c1d3f307a5313e49a0527f9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698