Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2078973002:
[mb] Add configs for more linux bots (Closed)
|
Created:
4 years, 6 months ago by Michael Achenbach Modified:
4 years, 6 months ago CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[mb] Add configs for more linux bots
BUG=chromium:616035
NOTRY=true
NOTREECHECKS=true
NOPRESUBMIT=true
Committed: https://crrev.com/1b3d9fa33d2d7752a7ca5fd78518f3d2e7d0dd66
Cr-Commit-Position: refs/heads/master@{#37101}
Patch Set 1 #Patch Set 2 #
Total comments: 3
Patch Set 3 : Typo #Messages
Total messages: 20 (10 generated)
Description was changed from ========== [mb] Add configs for more linux bots BUG= ========== to ========== [mb] Add configs for more linux bots BUG=chromium:616035 NOTRY=true ==========
machenbach@chromium.org changed reviewers: + jochen@chromium.org, kjellander@chromium.org, vogelheim@chromium.org
PTAL Please no rubber stamps. I added links to the runhooks steps on the bots to ease comparing gyp_defines. My comments are on patch 2 - patch 3 just corrects a typo. It's also possible to do am additional post review after this lands. I've added a feature that highlights the differences between infra and client-side and spits out a warning like so: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20custom%20s...
On 2016/06/20 06:54:25, Michael Achenbach wrote: > PTAL > > Please no rubber stamps. I added links to the runhooks steps on the bots to ease > comparing gyp_defines. My comments are on patch 2 - patch 3 just corrects a > typo. I don't see any comments. Did you forget to publish them? > It's also possible to do am additional post review after this lands. I've added > a feature that highlights the differences between infra and client-side and > spits out a warning like so: > https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20custom%20s...
Now with comments :) https://codereview.chromium.org/2078973002/diff/20001/infra/mb/mb_config.pyl File infra/mb/mb_config.pyl (right): https://codereview.chromium.org/2078973002/diff/20001/infra/mb/mb_config.pyl#... infra/mb/mb_config.pyl:12: # Linux. New bots in prod: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20builder/buil... https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug%20buil... https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20bui... https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20deb... https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20shared/build... https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20noi18n%20-%2... https://build.chromium.org/p/client.v8/builders/V8%20Linux%20gcc%204.8/builds... https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20vtunejit/bui... https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20predictable/... https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20full%20debug... https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20interpreted%... https://build.chromium.org/p/client.v8/builders/V8%20Random%20Deopt%20Fuzzer%... https://codereview.chromium.org/2078973002/diff/20001/infra/mb/mb_config.pyl#... infra/mb/mb_config.pyl:21: 'V8 Linux64 - debug builder': 'gyp_debug_x64_valgrind', Keeping the config names consistent: gyp/gn _ release/debug _ arch type _ other https://codereview.chromium.org/2078973002/diff/20001/infra/mb/mb_config.pyl#... infra/mb/mb_config.pyl:34: 'tryserver.v8': { New trybots in prod: https://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/750... https://build.chromium.org/p/tryserver.v8/builders/v8_linux_avx2_dbg/builds/1... https://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/b... https://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/753... https://build.chromium.org/p/tryserver.v8/builders/v8_linux_noi18n_rel_ng/bui... https://build.chromium.org/p/tryserver.v8/builders/v8_linux_gc_stress_dbg/bui... https://build.chromium.org/p/tryserver.v8/builders/v8_linux_nosnap_rel/builds... https://build.chromium.org/p/tryserver.v8/builders/v8_linux_nosnap_dbg/builds... https://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/b... https://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_rel/builds/7/...
lgtm
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2078973002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2078973002/40001
Description was changed from ========== [mb] Add configs for more linux bots BUG=chromium:616035 NOTRY=true ========== to ========== [mb] Add configs for more linux bots BUG=chromium:616035 NOTRY=true NOTREECHECKS=true NOPRESUBMIT=true ==========
The CQ bit was unchecked by machenbach@chromium.org
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2078973002/40001
Message was sent while issue was closed.
Description was changed from ========== [mb] Add configs for more linux bots BUG=chromium:616035 NOTRY=true NOTREECHECKS=true NOPRESUBMIT=true ========== to ========== [mb] Add configs for more linux bots BUG=chromium:616035 NOTRY=true NOTREECHECKS=true NOPRESUBMIT=true ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [mb] Add configs for more linux bots BUG=chromium:616035 NOTRY=true NOTREECHECKS=true NOPRESUBMIT=true ========== to ========== [mb] Add configs for more linux bots BUG=chromium:616035 NOTRY=true NOTREECHECKS=true NOPRESUBMIT=true Committed: https://crrev.com/1b3d9fa33d2d7752a7ca5fd78518f3d2e7d0dd66 Cr-Commit-Position: refs/heads/master@{#37101} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/1b3d9fa33d2d7752a7ca5fd78518f3d2e7d0dd66 Cr-Commit-Position: refs/heads/master@{#37101} |
