chrome/browser/ui/views/find_bar_view.cc - Issue 2078953003: Remove find bar focus redirection on mouse events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/find_bar_view.cc

Issue 2078953003: Remove find bar focus redirection on mouse events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove focus redirection altogether; update FindInPageTest. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/find_bar_view.cc

diff --git a/chrome/browser/ui/views/find_bar_view.cc b/chrome/browser/ui/views/find_bar_view.cc

index 8e74295faea968c688fe5799ed19196e93683040..7ff6b561d857fabb00781b00222af6b663cf4b50 100644

--- a/chrome/browser/ui/views/find_bar_view.cc

+++ b/chrome/browser/ui/views/find_bar_view.cc

@@ -426,11 +426,6 @@ void FindBarView::ButtonPressed(

sender->id() == VIEW_ID_FIND_IN_PAGE_NEXT_BUTTON,

false); // Not case sensitive.

}

- if (event.IsMouseEvent()) {

- // Move focus to the find textfield.

- find_text_->RequestFocus();

- }

break;

case VIEW_ID_FIND_IN_PAGE_CLOSE_BUTTON:

find_bar_host()->GetFindBarController()->EndFindSession(