Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1105)

Unified Diff: chrome/browser/ui/views/find_bar_view.cc

Issue 2078953003: Remove find bar focus redirection on mouse events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/find_bar_view.cc
diff --git a/chrome/browser/ui/views/find_bar_view.cc b/chrome/browser/ui/views/find_bar_view.cc
index 8e74295faea968c688fe5799ed19196e93683040..5facdcb6689c72b202a557a51c3082c1a2760a50 100644
--- a/chrome/browser/ui/views/find_bar_view.cc
+++ b/chrome/browser/ui/views/find_bar_view.cc
@@ -427,10 +427,10 @@ void FindBarView::ButtonPressed(
false); // Not case sensitive.
}
- if (event.IsMouseEvent()) {
- // Move focus to the find textfield.
+ // Focus the textfield, unless the button was invoked with a key press.
+ // That lets the user continuously press SPACE/ENTER on next/previous.
Peter Kasting 2016/06/17 20:55:47 Nit: We might want to note why we'd want to move f
msw 2016/06/18 00:25:18 As discussed, I'm removing this workaround added f
+ if (!event.IsKeyEvent())
find_text_->RequestFocus();
- }
break;
case VIEW_ID_FIND_IN_PAGE_CLOSE_BUTTON:
find_bar_host()->GetFindBarController()->EndFindSession(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698