chrome/installer/util/google_update_util.cc - Issue 2078913005: Add a chrome_elf_unittest ChromeElfLoadSanityTest which validates that loading chrome_elf does not …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/google_update_util.cc

Issue 2078913005: Add a chrome_elf_unittest ChromeElfLoadSanityTest which validates that loading chrome_elf does not … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Restore newline in CommandLine::Init Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/util/google_update_util.cc

diff --git a/chrome/installer/util/google_update_util.cc b/chrome/installer/util/google_update_util.cc

index 3a8558f56b0d2e66268f83c409501b8d05f8428b..42ddb1a00d4b8943c08fe6db79d01f9c0735a246 100644

--- a/chrome/installer/util/google_update_util.cc

+++ b/chrome/installer/util/google_update_util.cc

@@ -16,7 +16,6 @@

#include "base/win/registry.h"

#include "base/win/scoped_handle.h"

#include "base/win/win_util.h"

-#include "base/win/windows_version.h"

#include "chrome/installer/util/browser_distribution.h"

#include "chrome/installer/util/google_update_constants.h"

#include "chrome/installer/util/google_update_settings.h"

@@ -178,8 +177,7 @@ void ElevateIfNeededToReenableUpdates() {

base::LaunchOptions launch_options;

launch_options.force_breakaway_from_job_ = true;

- if (base::win::GetVersion() >= base::win::VERSION_VISTA &&

- base::win::UserAccountControlIsEnabled()) {

+ if (base::win::UserAccountControlIsEnabled()) {

grt (UTC plus 2) 2016/06/22 14:13:55 uber nit: omit braces

ananta 2016/06/22 18:43:52 Done.

base::LaunchElevatedProcess(cmd, launch_options);

} else {

base::LaunchProcess(cmd, launch_options);

« no previous file with comments | « base/message_loop/message_pump_win.cc ('k') | chrome_elf/BUILD.gn » ('j') | no next file with comments »