Add a chrome_elf_unittest ChromeElfLoadSanityTest which validates that loading chrome_elf does not …

chrome_elf/elf_imports_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdint.h>
 #include <windows.h>
 
 #include <algorithm>
 #include <vector>
 
@@ skipping 89 matching lines @@
     bool match = false;
     for (const char* kValidFilePattern : kValidFilePatterns) {
       if (base::MatchPattern(import, kValidFilePattern)) {
         match = true;
         break;
       }
     }
     ASSERT_TRUE(match) << "Illegal import in chrome_elf.dll: " << import;
   }
 }
+TEST_F(ELFImportsTest, ChromeElfLoadSanityTest) {
+  base::FilePath dll;
+  ASSERT_TRUE(PathService::Get(base::DIR_EXE, &dll));
+  dll = dll.Append(L"chrome_elf.dll");
+
+  // We don't expect user32 to be loaded in chrome_elf_unittests.
+  EXPECT_EQ(nullptr, ::GetModuleHandle(L"user32.dll"));

[robertshield, 2016/06/20 16:59:54]

Can you expand the comment here to explicitly state that if this line fails,
then a user32 dependency has crept into the unit test executable and should be
removed?

I'm worried that someone will e.g. change base::FilePath in a way that trips
this and they won't know how to proceed.

[ananta, 2016/06/20 19:08:03]

Done.

+
+  HMODULE chrome_elf_module_handle = ::LoadLibrary(dll.value().c_str());
+  EXPECT_TRUE(chrome_elf_module_handle != nullptr);
+  // Loading chrome_elf.dll should not load user32.dll
+  EXPECT_EQ(nullptr, ::GetModuleHandle(L"user32.dll"));
+  EXPECT_TRUE(!!::FreeLibrary(chrome_elf_module_handle));
+}
 #endif  // NDEBUG
 
 TEST_F(ELFImportsTest, ChromeExeSanityCheck) {
   std::vector<std::string> exe_imports;
 
   base::FilePath exe;
   ASSERT_TRUE(PathService::Get(base::DIR_EXE, &exe));
   exe = exe.Append(L"chrome.exe");
   GetImports(exe, &exe_imports);
 
   // Check that chrome.exe has imports.
   ASSERT_LT(0u, exe_imports.size()) << "Ensure the chrome_elf_unittests "
     "target was built, instead of chrome_elf_unittests.exe";
 
   // Chrome.exe's first import must be ELF.
   EXPECT_EQ("chrome_elf.dll", exe_imports[0]) <<
       "Illegal import order in chrome.exe (ensure the chrome_elf_unittest "
       "target was built, instead of just chrome_elf_unittests.exe)";
 }
 
 }  // namespace