Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2078913003: port to Sk4f (Closed)

Created:
4 years, 6 months ago by mtklein_C
Modified:
4 years, 6 months ago
Reviewers:
msarett
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

port SkColorXform_opts to Sk4f I have tested that this compiles. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2078913003 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Committed: https://skia.googlesource.com/skia/+/64f061a4e85bea6a48901b1385b7159f85909a34

Patch Set 1 #

Patch Set 2 : clearer, simpler, better for gcc? #

Patch Set 3 : neon, consistent order #

Patch Set 4 : alternative #

Patch Set 5 : orr #

Patch Set 6 : nah #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -135 lines) Patch
M src/opts/SkColorXform_opts.h View 1 2 4 5 5 chunks +46 lines, -135 lines 0 comments Download
M src/opts/SkNx_neon.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M src/opts/SkNx_sse.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
mtklein_C
4 years, 6 months ago (2016-06-17 17:53:59 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2078913003/1
4 years, 6 months ago (2016-06-17 17:54:07 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot/builds/7450) Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on ...
4 years, 6 months ago (2016-06-17 17:58:17 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2078913003/40001
4 years, 6 months ago (2016-06-17 18:31:28 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot/builds/9159)
4 years, 6 months ago (2016-06-17 18:36:19 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2078913003/80001
4 years, 6 months ago (2016-06-17 18:42:19 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2078913003/100001
4 years, 6 months ago (2016-06-17 18:53:49 UTC) #15
msarett
lgtm
4 years, 6 months ago (2016-06-17 19:04:15 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2078913003/100001
4 years, 6 months ago (2016-06-17 19:05:10 UTC) #19
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 19:09:19 UTC) #21
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/64f061a4e85bea6a48901b1385b7159f85909a34

Powered by Google App Engine
This is Rietveld 408576698