Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(899)

Side by Side Diff: src/gpu/effects/GrConvolutionEffect.h

Issue 20789003: Small optimization for convolution shader: only apply the bounds check in (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Make direction() context Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/effects/SkGpuBlurUtils.cpp ('k') | src/gpu/effects/GrConvolutionEffect.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 Google Inc. 2 * Copyright 2012 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #ifndef GrConvolutionEffect_DEFINED 8 #ifndef GrConvolutionEffect_DEFINED
9 #define GrConvolutionEffect_DEFINED 9 #define GrConvolutionEffect_DEFINED
10 10
11 #include "Gr1DKernelEffect.h" 11 #include "Gr1DKernelEffect.h"
12 12
13 class GrGLConvolutionEffect; 13 class GrGLConvolutionEffect;
14 14
15 /** 15 /**
16 * A convolution effect. The kernel is specified as an array of 2 * half-width 16 * A convolution effect. The kernel is specified as an array of 2 * half-width
17 * + 1 weights. Each texel is multiplied by it's weight and summed to determine 17 * + 1 weights. Each texel is multiplied by it's weight and summed to determine
18 * the output color. The output color is modulated by the input color. 18 * the output color. The output color is modulated by the input color.
19 */ 19 */
20 class GrConvolutionEffect : public Gr1DKernelEffect { 20 class GrConvolutionEffect : public Gr1DKernelEffect {
21 21
22 public: 22 public:
23 23
24 /// Convolve with an arbitrary user-specified kernel 24 /// Convolve with an arbitrary user-specified kernel
25 static GrEffectRef* Create(GrTexture* tex, 25 static GrEffectRef* Create(GrTexture* tex,
26 Direction dir, 26 Direction dir,
27 int halfWidth, 27 int halfWidth,
28 const float* kernel, 28 const float* kernel,
29 bool useCropRect, 29 bool useBounds,
30 float cropRect[4]) { 30 float bounds[2]) {
31 AutoEffectUnref effect(SkNEW_ARGS(GrConvolutionEffect, (tex, 31 AutoEffectUnref effect(SkNEW_ARGS(GrConvolutionEffect, (tex,
32 dir, 32 dir,
33 halfWidth, 33 halfWidth,
34 kernel, 34 kernel,
35 useCropRect, 35 useBounds,
36 cropRect))); 36 bounds)));
37 return CreateEffectRef(effect); 37 return CreateEffectRef(effect);
38 } 38 }
39 39
40 /// Convolve with a Gaussian kernel 40 /// Convolve with a Gaussian kernel
41 static GrEffectRef* CreateGaussian(GrTexture* tex, 41 static GrEffectRef* CreateGaussian(GrTexture* tex,
42 Direction dir, 42 Direction dir,
43 int halfWidth, 43 int halfWidth,
44 float gaussianSigma, 44 float gaussianSigma,
45 bool useCropRect, 45 bool useBounds,
46 float cropRect[4]) { 46 float bounds[2]) {
47 AutoEffectUnref effect(SkNEW_ARGS(GrConvolutionEffect, (tex, 47 AutoEffectUnref effect(SkNEW_ARGS(GrConvolutionEffect, (tex,
48 dir, 48 dir,
49 halfWidth, 49 halfWidth,
50 gaussianSigma, 50 gaussianSigma,
51 useCropRect, 51 useBounds,
52 cropRect))); 52 bounds)));
53 return CreateEffectRef(effect); 53 return CreateEffectRef(effect);
54 } 54 }
55 55
56 virtual ~GrConvolutionEffect(); 56 virtual ~GrConvolutionEffect();
57 57
58 const float* kernel() const { return fKernel; } 58 const float* kernel() const { return fKernel; }
59 59
60 const float* cropRect() const { return fCropRect; } 60 const float* bounds() const { return fBounds; }
61 bool useCropRect() const { return fUseCropRect; } 61 bool useBounds() const { return fUseBounds; }
62 62
63 static const char* Name() { return "Convolution"; } 63 static const char* Name() { return "Convolution"; }
64 64
65 typedef GrGLConvolutionEffect GLEffect; 65 typedef GrGLConvolutionEffect GLEffect;
66 66
67 virtual const GrBackendEffectFactory& getFactory() const SK_OVERRIDE; 67 virtual const GrBackendEffectFactory& getFactory() const SK_OVERRIDE;
68 68
69 virtual void getConstantColorComponents(GrColor*, uint32_t* validFlags) cons t { 69 virtual void getConstantColorComponents(GrColor*, uint32_t* validFlags) cons t {
70 // If the texture was opaque we could know that the output color if we k new the sum of the 70 // If the texture was opaque we could know that the output color if we k new the sum of the
71 // kernel values. 71 // kernel values.
72 *validFlags = 0; 72 *validFlags = 0;
73 } 73 }
74 74
75 enum { 75 enum {
76 // This was decided based on the min allowed value for the max texture 76 // This was decided based on the min allowed value for the max texture
77 // samples per fragment program run in DX9SM2 (32). A sigma param of 4.0 77 // samples per fragment program run in DX9SM2 (32). A sigma param of 4.0
78 // on a blur filter gives a kernel width of 25 while a sigma of 5.0 78 // on a blur filter gives a kernel width of 25 while a sigma of 5.0
79 // would exceed a 32 wide kernel. 79 // would exceed a 32 wide kernel.
80 kMaxKernelRadius = 12, 80 kMaxKernelRadius = 12,
81 // With a C++11 we could have a constexpr version of WidthFromRadius() 81 // With a C++11 we could have a constexpr version of WidthFromRadius()
82 // and not have to duplicate this calculation. 82 // and not have to duplicate this calculation.
83 kMaxKernelWidth = 2 * kMaxKernelRadius + 1, 83 kMaxKernelWidth = 2 * kMaxKernelRadius + 1,
84 }; 84 };
85 85
86 protected: 86 protected:
87 87
88 float fKernel[kMaxKernelWidth]; 88 float fKernel[kMaxKernelWidth];
89 bool fUseCropRect; 89 bool fUseBounds;
90 float fCropRect[4]; 90 float fBounds[2];
91 91
92 private: 92 private:
93 GrConvolutionEffect(GrTexture*, Direction, 93 GrConvolutionEffect(GrTexture*, Direction,
94 int halfWidth, 94 int halfWidth,
95 const float* kernel, 95 const float* kernel,
96 bool useCropRect, 96 bool useBounds,
97 float cropRect[4]); 97 float bounds[2]);
98 98
99 /// Convolve with a Gaussian kernel 99 /// Convolve with a Gaussian kernel
100 GrConvolutionEffect(GrTexture*, Direction, 100 GrConvolutionEffect(GrTexture*, Direction,
101 int halfWidth, 101 int halfWidth,
102 float gaussianSigma, 102 float gaussianSigma,
103 bool useCropRect, 103 bool useBounds,
104 float cropRect[4]); 104 float bounds[2]);
105 105
106 virtual bool onIsEqual(const GrEffect&) const SK_OVERRIDE; 106 virtual bool onIsEqual(const GrEffect&) const SK_OVERRIDE;
107 107
108 GR_DECLARE_EFFECT_TEST; 108 GR_DECLARE_EFFECT_TEST;
109 109
110 typedef Gr1DKernelEffect INHERITED; 110 typedef Gr1DKernelEffect INHERITED;
111 }; 111 };
112 112
113 #endif 113 #endif
OLDNEW
« no previous file with comments | « src/effects/SkGpuBlurUtils.cpp ('k') | src/gpu/effects/GrConvolutionEffect.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698