Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Unified Diff: components/content_settings/core/browser/host_content_settings_map.h

Issue 2078893002: Add callback list to PrefModelAssociator after sync data is loaded (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@migrate_domain_scoped_settings
Patch Set: remove unused things Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/content_settings/core/browser/host_content_settings_map.h
diff --git a/components/content_settings/core/browser/host_content_settings_map.h b/components/content_settings/core/browser/host_content_settings_map.h
index b5af0111f8c063d2fd5a7d9cbb16530903957f91..1113f6256773afe972b2871f3c7354d300281ab6 100644
--- a/components/content_settings/core/browser/host_content_settings_map.h
+++ b/components/content_settings/core/browser/host_content_settings_map.h
@@ -278,6 +278,14 @@ class HostContentSettingsMap : public content_settings::Observer,
// Passes ownership of |clock|.
void SetPrefClockForTesting(std::unique_ptr<base::Clock> clock);
+ // Migrate old domain scoped ALLOW settings to be origin scoped for
+ // ContentSettingsTypes which are domain scoped. Only narrow down ALLOW
+ // domain settings to origins so that this will not cause privacy/security
+ // issues.
+ // TODO(lshang): https://crbug.com/621398 Remove this when clients have
+ // migrated (~M55).
+ void MigrateDomainScopedSettings();
+
private:
friend class base::RefCountedThreadSafe<HostContentSettingsMap>;
friend class HostContentSettingsMapTest_MigrateDomainScopedSettings_Test;
@@ -312,14 +320,6 @@ class HostContentSettingsMap : public content_settings::Observer,
// leave in some code to remove old-format settings for a long time.
void MigrateKeygenSettings();
- // Migrate old domain scoped ALLOW settings to be origin scoped for
- // ContentSettingsTypes which are domain scoped. Only narrow down ALLOW
- // domain settings to origins so that this will not cause privacy/security
- // issues.
- // TODO(lshang): https://crbug.com/621398 Remove this when clients have
- // migrated (~M55).
- void MigrateDomainScopedSettings();
-
// Collect UMA data about the number of exceptions.
void RecordNumberOfExceptions();

Powered by Google App Engine
This is Rietveld 408576698