Add callback list to PrefModelAssociator after sync data is loaded

components/syncable_prefs/pref_service_syncable_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/syncable_prefs/pref_service_syncable.h"
 
 #include <stdint.h>
 
 #include "base/json/json_reader.h"
 #include "base/json/json_string_value_serializer.h"
@@ skipping 28 matching lines @@
 const char kExampleUrl1[] = "http://example.com/1";
 const char kExampleUrl2[] = "http://example.com/2";
 const char kStringPrefName[] = "string_pref_name";
 const char kListPrefName[] = "list_pref_name";
 const char kUnsyncedPreferenceName[] = "nonsense_pref_name";
 const char kUnsyncedPreferenceDefaultValue[] = "default";
 const char kDefaultCharsetPrefName[] = "default_charset";
 const char kNonDefaultCharsetValue[] = "foo";
 const char kDefaultCharsetValue[] = "utf-8";
 
+int kNumCallbacks = 0;
+void CallbackFunc(int* num) {
+  (*num)++;
+}
+
 class TestPrefModelAssociatorClient : public PrefModelAssociatorClient {
  public:
   TestPrefModelAssociatorClient() {}
   ~TestPrefModelAssociatorClient() override {}
 
   // PrefModelAssociatorClient implementation.
   bool IsMergeableListPreference(const std::string& pref_name) const override {
     return pref_name == kListPrefName;
   }
 
@@ skipping 55 matching lines @@
         kListPrefName,
         user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
     prefs_.registry()->RegisterStringPref(
         kDefaultCharsetPrefName,
         kDefaultCharsetValue,
         user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
 
     pref_sync_service_ = reinterpret_cast<PrefModelAssociator*>(
         prefs_.GetSyncableService(syncer::PREFERENCES));
     ASSERT_TRUE(pref_sync_service_);
-    next_pref_remote_sync_node_id_ = 0;
   }
 
   syncer::SyncChange MakeRemoteChange(int64_t id,
                                       const std::string& name,
                                       const base::Value& value,
                                       SyncChange::SyncChangeType type) {
     std::string serialized;
     JSONStringValueSerializer json(&serialized);
     if (!json.Serialize(value))
       return syncer::SyncChange();
@@ skipping 413 matching lines @@
   InitWithNoSyncData();
 
   std::unique_ptr<base::Value> null_value = base::Value::CreateNullValue();
   syncer::SyncChangeList list;
   list.push_back(MakeRemoteChange(
       1, kStringPrefName, *null_value, SyncChange::ACTION_DELETE));
   pref_sync_service_->ProcessSyncChanges(FROM_HERE, list);
   EXPECT_TRUE(pref->IsDefaultValue());
 }
 
+TEST_F(PrefServiceSyncableTest, RegisterMergeDataFinishedCallback) {
+  EXPECT_EQ(0, kNumCallbacks);
+  prefs_.RegisterMergeDataFinishedCallback(
+      base::Bind(&CallbackFunc, &kNumCallbacks));

[raymes, 2016/07/14 02:58:51]

can kNumCallbacks be a local variable?

[lshang, 2016/07/14 04:10:24]

Done.

+  EXPECT_EQ(0, kNumCallbacks);
+  InitWithNoSyncData();
+  EXPECT_EQ(1, kNumCallbacks);
+}
+
 }  // namespace
 
 }  // namespace syncable_prefs