Add callback list to PrefModelAssociator after sync data is loaded

chrome/browser/content_settings/host_content_settings_map_factory.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/content_settings/host_content_settings_map_factory.h"
 
 #include <utility>
 
+#include "chrome/browser/prefs/pref_service_syncable_util.h"
 #include "chrome/browser/profiles/off_the_record_profile_impl.h"
 #include "chrome/browser/profiles/profile.h"
 #include "components/content_settings/core/browser/host_content_settings_map.h"
 #include "components/keyed_service/content/browser_context_dependency_manager.h"
 #include "content/public/browser/browser_thread.h"
 
 #if defined(ENABLE_EXTENSIONS)
 #include "chrome/browser/extensions/extension_service.h"
 #include "extensions/browser/extension_system.h"
 #include "extensions/browser/extension_system_provider.h"
@@ skipping 46 matching lines @@
   // If off the record, retrieve the host content settings map of the parent
   // profile in order to ensure the preferences have been migrated.
   if (profile->GetProfileType() == Profile::INCOGNITO_PROFILE)
     GetForProfile(profile->GetOriginalProfile());
 
   scoped_refptr<HostContentSettingsMap> settings_map(new HostContentSettingsMap(
       profile->GetPrefs(),
       profile->GetProfileType() == Profile::INCOGNITO_PROFILE,
       profile->GetProfileType() == Profile::GUEST_PROFILE));
 
+// TODO(lshang): Make this not a comment when we change scoping type and hook up

[Bernhard Bauer, 2016/07/07 08:50:08]

The comment should be indented at the same level as the surrounding code, which
is two spaces here.

[lshang, 2016/07/13 06:27:28]

I moved this code block to the following CL, so this comment is deleted there.

+// the migration code.
+/*  syncable_prefs::PrefServiceSyncable* pref_service =

[Bernhard Bauer, 2016/07/07 08:50:08]

And this comment should use the regular double-slash style.

[lshang, 2016/07/13 06:27:28]

Also with this comment sign.

+      PrefServiceSyncableFromProfile(profile);
+  if (pref_service)

[Bernhard Bauer, 2016/07/07 08:50:08]

Add braces, as the body spans more than a single line.

[lshang, 2016/07/13 06:27:28]

Done in the following CL.

+    pref_service->RegisterMergeDataFinishedCallback(base::Bind(
+        &HostContentSettingsMap::MigrateDomainScopedSettings, settings_map));*/

[Bernhard Bauer, 2016/07/07 08:50:08]

You are going to have to figure out the lifetime story here with regards to
|settings_map|. Can you guarantee that |settings_map| is alive when the callback
runs? If so, you can use base::Unretained(). If not, you'll have to find some
other way.

[raymes, 2016/07/13 03:20:20]

I don't think we can make that guarantee (that I know of). I think we should get
a weak pointer from the HostContentSettingsMap.

[lshang, 2016/07/13 06:27:28]

Done.

+
 #if defined(ENABLE_EXTENSIONS)
   ExtensionService *ext_service =
       extensions::ExtensionSystem::Get(profile)->extension_service();
   // This may be null in testing or when the extenion_service hasn't been
   // initialized, in which case it will be registered then.
   if (ext_service)
     ext_service->RegisterContentSettings(settings_map.get());
 #endif // defined(ENABLE_EXTENSIONS)
 #if defined(ENABLE_SUPERVISED_USERS)
   SupervisedUserSettingsService* supervised_service =
       SupervisedUserSettingsServiceFactory::GetForProfile(profile);
   // This may be null in testing.
   if (supervised_service) {
     std::unique_ptr<content_settings::SupervisedProvider> supervised_provider(
         new content_settings::SupervisedProvider(supervised_service));
     settings_map->RegisterProvider(HostContentSettingsMap::SUPERVISED_PROVIDER,
                                    std::move(supervised_provider));
   }
 #endif // defined(ENABLE_SUPERVISED_USERS)
 
   return settings_map;
 }
 
 content::BrowserContext* HostContentSettingsMapFactory::GetBrowserContextToUse(
     content::BrowserContext* context) const {
   return context;
 }