Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2078863002: Reland "[heap] Add page evacuation mode for new->new" (Closed)

Created:
4 years, 6 months ago by Michael Lippautz
Modified:
4 years, 6 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "[heap] Add page evacuation mode for new->new" Adds an evacuation mode that allows moving pages within new space without copying objects. Basic idea: a) Move page within new space b) Sweep page to make iterable and process ArrayBuffers c) Finish sweep till next scavenge Threshold is currently 70% live bytes, i.e., the same threshold we use to determine fragmented pages. This reverts commit 2263ee9bf4e5aa341cbac547add68a2105963477. BUG=chromium:581412 LOG=N CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_arm64_gc_stress_dbg,v8_linux_gc_stress_dbg,v8_mac_gc_stress_dbg,v8_linux64_tsan_rel,v8_mac64_asan_rel Committed: https://crrev.com/7d5969da3d2b1a9b08c6fc6517d69f8ca4aca94c Cr-Commit-Position: refs/heads/master@{#37104}

Patch Set 1 : base #

Patch Set 2 : Avoid adding new pages for fragmented to space. Instead, force promotion. #

Total comments: 2

Patch Set 3 : Address comment #

Patch Set 4 : Add test to test/cctest/BUILD.gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+468 lines, -239 lines) Patch
M src/heap/heap.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/mark-compact.h View 4 chunks +4 lines, -2 lines 0 comments Download
M src/heap/mark-compact.cc View 1 2 24 chunks +249 lines, -158 lines 0 comments Download
M src/heap/spaces.h View 1 2 12 chunks +27 lines, -11 lines 0 comments Download
M src/heap/spaces.cc View 1 5 chunks +55 lines, -18 lines 0 comments Download
M test/cctest/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +0 lines, -50 lines 0 comments Download
A test/cctest/heap/test-page-promotion.cc View 1 chunk +129 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2078863002/20001
4 years, 6 months ago (2016-06-17 08:05:16 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/9003) v8_win64_rel_ng_triggered on ...
4 years, 6 months ago (2016-06-17 08:36:54 UTC) #6
Michael Lippautz
ptal, PS1->PS2 solves the fragmentation issue.
4 years, 6 months ago (2016-06-17 08:55:01 UTC) #7
ulan
lgtm https://codereview.chromium.org/2078863002/diff/20001/src/heap/spaces.h File src/heap/spaces.h (right): https://codereview.chromium.org/2078863002/diff/20001/src/heap/spaces.h#newcode2462 src/heap/spaces.h:2462: if (next_page == anchor() || (pages_used_ == max_pages())) ...
4 years, 6 months ago (2016-06-17 13:59:48 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2078863002/60001
4 years, 6 months ago (2016-06-17 14:30:08 UTC) #10
Michael Lippautz
Also added the test to test/cctest/BUILD.gn https://codereview.chromium.org/2078863002/diff/20001/src/heap/spaces.h File src/heap/spaces.h (right): https://codereview.chromium.org/2078863002/diff/20001/src/heap/spaces.h#newcode2462 src/heap/spaces.h:2462: if (next_page == ...
4 years, 6 months ago (2016-06-17 14:32:03 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-17 15:09:57 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2078863002/60001
4 years, 6 months ago (2016-06-20 12:37:52 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-20 13:19:43 UTC) #18
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 13:24:24 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/7d5969da3d2b1a9b08c6fc6517d69f8ca4aca94c
Cr-Commit-Position: refs/heads/master@{#37104}

Powered by Google App Engine
This is Rietveld 408576698