Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2078833004: Change back to destroy the CDM synchronously (Closed)

Created:
4 years, 6 months ago by jrummell
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Change back to destroy the CDM synchronously Outstanding promises may get rejected due to blink garbage collection destroying all the remaining EME objects when they are no longer referenced. The original fix destroyed the CDM asynchronously. However, that causes problems as the CDM may hold references to objects owned by RenderFrameImpl, and they may get accessed after ~RenderFrameImpl. This fix posts a task to reject the promise asynchronously. That way any outstanding promises that need to be rejected are handled after gc is done. It affects all EME promise rejections (from Chromium). Resolving promises is still done synchronously as there may be events already posted that need to happen only after the promise is resolved. BUG=597355 TEST=existing EME tests still pass Review-Url: https://codereview.chromium.org/1987883002 Cr-Commit-Position: refs/heads/master@{#398986} (cherry picked from commit 3135b5eec1c39fb213cbf906f81553efa8cbaf67) Committed: https://chromium.googlesource.com/chromium/src/+/4f09e0e74ee9520929b78c7234679d78ca635c64

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -16 lines) Patch
M media/blink/cdm_session_adapter.cc View 1 chunk +1 line, -15 lines 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/ContentDecryptionModuleResultPromise.h View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/ContentDecryptionModuleResultPromise.cpp View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jrummell
4 years, 6 months ago (2016-06-17 23:53:21 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4f09e0e74ee9520929b78c7234679d78ca635c64.

Powered by Google App Engine
This is Rietveld 408576698