media/blink/test_response_generator.h - Issue 2078833003: fix a semi-rare crash in multibuffers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/blink/test_response_generator.h

Issue 2078833003: fix a semi-rare crash in multibuffers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: test added Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/blink/test_response_generator.h

diff --git a/media/blink/test_response_generator.h b/media/blink/test_response_generator.h

index ce76aa62de01add56e5069413f89032c39b7c6b9..723ff4c8de51e52f014038c605fb907572833735 100644

--- a/media/blink/test_response_generator.h

+++ b/media/blink/test_response_generator.h

@@ -57,7 +57,7 @@ class TestResponseGenerator {

Flags flags);

// Generates a regular HTTP 404 response.

- blink::WebURLResponse Generate404();

+ blink::WebURLResponse Generate404(int code = 404);

liberato (no reviews please) 2016/06/18 06:03:14 Perhaps add a new function GenerateResponse(int co

hubbe 2016/06/20 18:59:50 Done.

// Generates a file:// response starting from |first_byte_offset| until the

// end of the resource.