fix a semi-rare crash in multibuffers

fix a semi-rare crash in multibuffers

Currently, getting an unsatisfiable range error will crash multibuffers.
That shouldn't normally happen if the server is sane, which is of course not guaranteed.

BUG=622059
Committed: https://crrev.com/625ddd981c1a8e0496d0227c374e4a445b81d2a0
Cr-Commit-Position: refs/heads/master@{#400766}

[hubbe, 2016-06-18 00:01:24]

hubbe@chromium.org changed reviewers:
+ liberato@chromium.org

[liberato (no reviews please), 2016-06-18 06:03:15]

lgtm

https://codereview.chromium.org/2078833003/diff/20001/media/blink/resource_mu...
File media/blink/resource_multibuffer_data_provider.cc (right):

https://codereview.chromium.org/2078833003/diff/20001/media/blink/resource_mu...
media/blink/resource_multibuffer_data_provider.cc:293: // url_data_ hasn't been
updaed to the final destination yet.
/updaed/updated/

https://codereview.chromium.org/2078833003/diff/20001/media/blink/test_respon...
File media/blink/test_response_generator.h (right):

https://codereview.chromium.org/2078833003/diff/20001/media/blink/test_respon...
media/blink/test_response_generator.h:60: blink::WebURLResponse Generate404(int
code = 404);
Perhaps add a new function GenerateResponse(int code).  Generate404(416)
requires very large values of 404.  :)

[hubbe, 2016-06-20 18:59:51]

https://codereview.chromium.org/2078833003/diff/20001/media/blink/resource_mu...
File media/blink/resource_multibuffer_data_provider.cc (right):

https://codereview.chromium.org/2078833003/diff/20001/media/blink/resource_mu...
media/blink/resource_multibuffer_data_provider.cc:293: // url_data_ hasn't been
updaed to the final destination yet.
On 2016/06/18 06:03:14, liberato wrote:
> /updaed/updated/

Done.

https://codereview.chromium.org/2078833003/diff/20001/media/blink/test_respon...
File media/blink/test_response_generator.h (right):

https://codereview.chromium.org/2078833003/diff/20001/media/blink/test_respon...
media/blink/test_response_generator.h:60: blink::WebURLResponse Generate404(int
code = 404);
On 2016/06/18 06:03:14, liberato wrote:
> Perhaps add a new function GenerateResponse(int code).  Generate404(416)
> requires very large values of 404.  :)

Done.

[hubbe, 2016-06-20 18:59:58]

The CQ bit was checked by hubbe@chromium.org

[hubbe, 2016-06-20 18:59:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
liberato@chromium.org
Link to the patchset: https://codereview.chromium.org/2078833003/#ps40001
(title: "comments addressed")

[commit-bot: I haz the power, 2016-06-20 19:00:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2078833003/40001

[commit-bot: I haz the power, 2016-06-20 20:29:57]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-20 20:35:05]

Description was changed from

==========
fix a semi-rare crash in multibuffers

Currently, getting an unsatisfiable range error will crash multibuffers.
That shouldn't normally happen if the server is sane, which is of course not
guaranteed.
==========

to

==========
fix a semi-rare crash in multibuffers

Currently, getting an unsatisfiable range error will crash multibuffers.
That shouldn't normally happen if the server is sane, which is of course not
guaranteed.

Committed: https://crrev.com/625ddd981c1a8e0496d0227c374e4a445b81d2a0
Cr-Commit-Position: refs/heads/master@{#400766}
==========

[commit-bot: I haz the power, 2016-06-20 20:35:06]

Patchset 3 (id:??) landed as
https://crrev.com/625ddd981c1a8e0496d0227c374e4a445b81d2a0
Cr-Commit-Position: refs/heads/master@{#400766}

[DaleCurtis, 2016-06-23 00:49:22]

dalecurtis@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[DaleCurtis, 2016-06-23 00:49:22]

Can you attach a bug to this and merge it back to M52?

[hubbe, 2016-06-23 18:05:03]

Description was changed from

==========
fix a semi-rare crash in multibuffers

Currently, getting an unsatisfiable range error will crash multibuffers.
That shouldn't normally happen if the server is sane, which is of course not
guaranteed.

Committed: https://crrev.com/625ddd981c1a8e0496d0227c374e4a445b81d2a0
Cr-Commit-Position: refs/heads/master@{#400766}
==========

to

==========
fix a semi-rare crash in multibuffers

Currently, getting an unsatisfiable range error will crash multibuffers.
That shouldn't normally happen if the server is sane, which is of course not
guaranteed.

BUG=622059

Committed: https://crrev.com/625ddd981c1a8e0496d0227c374e4a445b81d2a0
Cr-Commit-Position: refs/heads/master@{#400766}
==========