Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 2078773002: Revert of bluetooth: mac: Initial BluetoothRemoteGattCharacteristicMac implementation (Closed)

Created:
4 years, 6 months ago by ortuno
Modified:
4 years, 6 months ago
CC:
blink-reviews, chromium-reviews, haraken, ortuno+watch_chromium.org, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@servicescan_cleanup
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of bluetooth: mac: Initial BluetoothRemoteGattCharacteristicMac implementation (patchset #15 id:280001 of https://codereview.chromium.org/1950033002/ ) Reason for revert: Breaks mac bot: https://bugs.chromium.org/p/chromium/issues/detail?id=620917#c1 Original issue's description: > bluetooth: mac: Initial BluetoothRemoteGattCharacteristicMac implementation > > Adding initial remote characteristic implementation on OS X, with only the basic methods (e.g. GetUUID) implemented. > > Characteristic discovery also implemented in BluetoothRemoteGattServiceMac. > > BUG=609064 > > Committed: https://crrev.com/6af3e124c3e3745f280d3b0c5c9491a5e603340f > Committed: https://crrev.com/027333819f3fb880a7e433157dfc4c55d3bf8268 > Cr-Original-Commit-Position: refs/heads/master@{#400127} > Cr-Commit-Position: refs/heads/master@{#400266} TBR=fbeaufort@chromium.org,msarda@chromium.org,scheib@chromium.org,jlebel@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=609064 Committed: https://crrev.com/158fd7ff3a856250c253e92a469b00cf3852b113 Cr-Commit-Position: refs/heads/master@{#400314}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -740 lines) Patch
M device/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M device/bluetooth/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_low_energy_device_mac.h View 2 chunks +0 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_low_energy_device_mac.mm View 2 chunks +5 lines, -39 lines 0 comments Download
M device/bluetooth/bluetooth_low_energy_peripheral_delegate.mm View 2 chunks +0 lines, -10 lines 0 comments Download
D device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h View 1 chunk +0 lines, -72 lines 0 comments Download
D device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm View 1 chunk +0 lines, -151 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc View 4 chunks +11 lines, -27 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_service_mac.h View 2 chunks +1 line, -26 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_service_mac.mm View 4 chunks +5 lines, -89 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_service_unittest.cc View 6 chunks +15 lines, -30 lines 0 comments Download
M device/bluetooth/test/bluetooth_test_mac.h View 3 chunks +0 lines, -16 lines 0 comments Download
M device/bluetooth/test/bluetooth_test_mac.mm View 5 chunks +2 lines, -63 lines 0 comments Download
D device/bluetooth/test/mock_bluetooth_cbcharacteristic_mac.h View 1 chunk +0 lines, -23 lines 0 comments Download
D device/bluetooth/test/mock_bluetooth_cbcharacteristic_mac.mm View 1 chunk +0 lines, -120 lines 0 comments Download
M device/bluetooth/test/mock_bluetooth_cbperipheral_mac.h View 1 chunk +0 lines, -2 lines 0 comments Download
M device/bluetooth/test/mock_bluetooth_cbperipheral_mac.mm View 4 chunks +3 lines, -22 lines 0 comments Download
M device/bluetooth/test/mock_bluetooth_cbservice_mac.h View 2 chunks +1 line, -9 lines 0 comments Download
M device/bluetooth/test/mock_bluetooth_cbservice_mac.mm View 3 chunks +1 line, -28 lines 0 comments Download
M device/device_tests.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +25 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ortuno
Created Revert of bluetooth: mac: Initial BluetoothRemoteGattCharacteristicMac implementation
4 years, 6 months ago (2016-06-17 00:31:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2078773002/1
4 years, 6 months ago (2016-06-17 00:33:18 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-17 00:34:32 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 00:35:36 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/158fd7ff3a856250c253e92a469b00cf3852b113
Cr-Commit-Position: refs/heads/master@{#400314}

Powered by Google App Engine
This is Rietveld 408576698