Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2078743002: [Courgette] Make BSDiff search() use lexicographical_compare(). (Closed)

Created:
4 years, 6 months ago by huangs
Modified:
4 years, 5 months ago
Reviewers:
chrisha
CC:
chromium-reviews, wfh+watch_chromium.org, huangs+watch_chromium.org, Will Harris
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Courgette] Make BSDiff search() use lexicographical_compare(). Other changes: - Moved search() to new file bsdiff_search.h. - Created BSDiffSearchTest, taking 1 test from QSufSortTest and adding 1 new test. BUG=620867 Committed: https://crrev.com/01c1c6c377ec5df7ea13e931794dd5d393736f2c Cr-Commit-Position: refs/heads/master@{#402476}

Patch Set 1 #

Patch Set 2 : Fix comments; format. #

Patch Set 3 : Fix #include; add a few more test cases. #

Patch Set 4 : Fix base::StringPrintf() format. #

Patch Set 5 : Move search() to new file. #

Patch Set 6 : Remove verbose test output. #

Patch Set 7 : Sync. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -128 lines) Patch
M courgette/BUILD.gn View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M courgette/courgette.gyp View 1 2 3 4 3 chunks +4 lines, -2 lines 0 comments Download
M courgette/third_party/bsdiff/bsdiff_create.cc View 1 2 3 4 3 chunks +2 lines, -2 lines 0 comments Download
A courgette/third_party/bsdiff/bsdiff_search.h View 1 2 3 4 1 chunk +101 lines, -0 lines 0 comments Download
A courgette/third_party/bsdiff/bsdiff_search_unittest.cc View 1 2 3 4 5 1 chunk +128 lines, -0 lines 0 comments Download
M courgette/third_party/bsdiff/qsufsort.h View 1 2 3 4 2 chunks +1 line, -44 lines 0 comments Download
M courgette/third_party/bsdiff/qsufsort_unittest.cc View 1 2 3 4 5 2 chunks +4 lines, -80 lines 0 comments Download

Messages

Total messages: 37 (19 generated)
huangs
Just 1 line of main change. Verified that test fails without fix, and works with ...
4 years, 6 months ago (2016-06-16 23:09:24 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2078743002/40001
4 years, 6 months ago (2016-06-16 23:21:13 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/229834) linux_chromium_compile_dbg_ng on ...
4 years, 6 months ago (2016-06-16 23:42:25 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2078743002/60001
4 years, 6 months ago (2016-06-17 00:08:17 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/128794)
4 years, 6 months ago (2016-06-17 00:21:11 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2078743002/80001
4 years, 6 months ago (2016-06-17 15:07:41 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/83296)
4 years, 6 months ago (2016-06-17 15:48:44 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2078743002/100001
4 years, 6 months ago (2016-06-20 18:03:29 UTC) #19
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-20 19:08:04 UTC) #21
huangs
Sending review to chrisha@, PTAL. Thanks!
4 years, 6 months ago (2016-06-20 19:53:05 UTC) #23
chrisha
I like the thorough new test! lgtm
4 years, 5 months ago (2016-06-27 20:43:14 UTC) #24
huangs
Thanks. Want to commit, but so far the timing experiments seem inconclusive, so I want ...
4 years, 5 months ago (2016-06-27 23:20:11 UTC) #25
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2078743002/120001
4 years, 5 months ago (2016-06-28 07:07:58 UTC) #27
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-28 08:16:31 UTC) #29
huangs
Result of experiment (detailed in the http://crbug.com/620867): Data's noisy, but if there's slow down it's ...
4 years, 5 months ago (2016-06-28 15:23:04 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2078743002/120001
4 years, 5 months ago (2016-06-28 15:23:25 UTC) #33
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 5 months ago (2016-06-28 15:27:20 UTC) #35
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 15:29:26 UTC) #37
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/01c1c6c377ec5df7ea13e931794dd5d393736f2c
Cr-Commit-Position: refs/heads/master@{#402476}

Powered by Google App Engine
This is Rietveld 408576698