Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1029)

Issue 2078733002: [Mac] Fix Toolbar glimpse during fullscreen transition (Closed)

Created:
4 years, 6 months ago by spqchan
Modified:
4 years, 6 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Fix Toolbar glimpse during fullscreen transition BUG=618594, 615810 Committed: https://crrev.com/04542485cce24e64e794c1dfd47d97fa5fbdf20c Cr-Commit-Position: refs/heads/master@{#400450}

Patch Set 1 #

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M chrome/browser/ui/cocoa/browser_window_controller.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/presentation_mode_controller.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/presentation_mode_controller.mm View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
spqchan
PTAL
4 years, 6 months ago (2016-06-17 00:07:00 UTC) #3
Robert Sesek
LGTM
4 years, 6 months ago (2016-06-17 16:51:07 UTC) #4
spqchan
On 2016/06/17 16:51:07, Robert Sesek wrote: > LGTM thanks!
4 years, 6 months ago (2016-06-17 16:53:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2078733002/20001
4 years, 6 months ago (2016-06-17 16:53:27 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-17 17:33:27 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 17:35:03 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/04542485cce24e64e794c1dfd47d97fa5fbdf20c
Cr-Commit-Position: refs/heads/master@{#400450}

Powered by Google App Engine
This is Rietveld 408576698