Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 207873002: Fix compiler_version.py on systems with non-English locale. (Closed)

Created:
6 years, 9 months ago by mithro-old
Modified:
6 years, 9 months ago
Reviewers:
Lei Zhang, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix compiler_version.py on systems with non-English locale. The the version string can be localized! The regexs assume English formatting and will fail to match under other localization (such as when the versions dots become commas). http://www.gnu.org/software/gettext/manual/html_node/Locale-Environment-Variables.html#Locale-Environment-Variables BUG=354231 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258867

Patch Set 1 #

Patch Set 2 : Small comment fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M build/compiler_version.py View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mithro-old
Small fix for bug https://code.google.com/p/chromium/issues/detail?id=354231
6 years, 9 months ago (2014-03-21 09:34:11 UTC) #1
mithro-old
Hi pdknsk, Can you please see if this CL fixes the issue you where having ...
6 years, 9 months ago (2014-03-21 09:38:28 UTC) #2
pdknsk
works
6 years, 9 months ago (2014-03-21 09:44:29 UTC) #3
Nico
lgtm Maybe add a comment above the new line saying why it's there ("Else, --version ...
6 years, 9 months ago (2014-03-21 10:34:19 UTC) #4
mithro-old
The CQ bit was checked by mithro@mithis.com
6 years, 9 months ago (2014-03-24 01:17:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mithro@mithis.com/207873002/20001
6 years, 9 months ago (2014-03-24 01:17:19 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-24 03:40:03 UTC) #7
Message was sent while issue was closed.
Change committed as 258867

Powered by Google App Engine
This is Rietveld 408576698