Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2078713002: swarming: do not leak cache dirs in tests (Closed)

Created:
4 years, 6 months ago by nodir1
Modified:
4 years, 6 months ago
Reviewers:
nodir, M-A Ruel
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/luci/luci-py@master
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

swarming: do not leak cache dirs in tests run_isolated.py did not spcify cache dir, so a dir in cwd was used. Use a dir in tempdir instead. R=maruel@chromium.org BUG= Committed: https://github.com/luci/luci-py/commit/221608d40eb45409eb6cd15010b6f69d3aecf306

Patch Set 1 #

Patch Set 2 : swarming: do not leak cipd_cache in tests #

Patch Set 3 : fix test_main_naked_without_isolated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M client/tests/run_isolated_test.py View 1 2 3 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
nodir
PTAL
4 years, 6 months ago (2016-06-16 22:30:15 UTC) #2
M-A Ruel
lgtm
4 years, 6 months ago (2016-06-17 00:46:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2078713002/40001
4 years, 6 months ago (2016-06-17 00:55:17 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 00:56:56 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://github.com/luci/luci-py/commit/221608d40eb45409eb6cd15010b6f69d3aecf306

Powered by Google App Engine
This is Rietveld 408576698