Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: components/arc/intent_helper/local_activity_resolver.h

Issue 2078683002: Add handler and mojo interface to accept android intent filters. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Store intent filers in LocalActivityResolver. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/arc/intent_helper/local_activity_resolver.h
diff --git a/components/arc/intent_helper/local_activity_resolver.h b/components/arc/intent_helper/local_activity_resolver.h
index 0b5fcdd9d37abdb45d26539d4e586c0362ad207a..ad50f565349c091a0bd2a8003b3bef3ac8c358c9 100644
--- a/components/arc/intent_helper/local_activity_resolver.h
+++ b/components/arc/intent_helper/local_activity_resolver.h
@@ -6,19 +6,26 @@
#define COMPONENTS_ARC_INTENT_HELPER_LOCAL_ACTIVITY_HELPER_H_
#include "base/macros.h"
+#include "base/memory/ref_counted.h"
+#include "components/arc/common/intent_helper.mojom.h"
+#include "mojo/public/cpp/bindings/binding.h"
class GURL;
namespace arc {
-class LocalActivityResolver {
+class LocalActivityResolver : public base::RefCounted<LocalActivityResolver> {
public:
LocalActivityResolver() = default;
- ~LocalActivityResolver() = default;
bool ShouldChromeHandleUrl(const GURL& url);
+ void UpdateIntentFilters(mojo::Array<mojom::IntentFilterPtr>& intent_filters);
Yusuke Sato 2016/06/17 21:51:15 Is '&' necessary?
zentaro 2016/06/17 23:37:35 Yes - otherwise is will try to copy which isn't al
private:
+ friend class base::RefCounted<LocalActivityResolver>;
+ ~LocalActivityResolver() = default;
+
+ mojo::Array<mojom::IntentFilterPtr> intent_filters_;
Yusuke Sato 2016/06/17 21:51:15 Mind adding a code comment to explain what this is
zentaro 2016/06/17 23:37:35 Done.
DISALLOW_COPY_AND_ASSIGN(LocalActivityResolver);
};

Powered by Google App Engine
This is Rietveld 408576698