Add an out parameter to VerifyCertificateChain for retrieving the trusted chain.

net/cert/internal/verify_certificate_chain_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cert/internal/verify_certificate_chain.h"
 
 #include "base/base_paths.h"
 #include "base/files/file_util.h"
 #include "base/path_service.h"
 #include "base/strings/string_split.h"
@@ skipping 96 matching lines @@
 
   std::vector<scoped_refptr<net::ParsedCertificate>> input_chain;
   for (const auto& cert_der : chain) {
     ASSERT_TRUE(net::ParsedCertificate::CreateAndAddToVector(
         reinterpret_cast<const uint8_t*>(cert_der.data()), cert_der.size(),
         net::ParsedCertificate::DataSource::EXTERNAL_REFERENCE, &input_chain));
   }
 
   SimpleSignaturePolicy signature_policy(1024);
 
-  bool result =
-      VerifyCertificateChain(input_chain, trust_store, &signature_policy, time);
+  bool result = VerifyCertificateChain(input_chain, trust_store,

[eroman, 2016/06/16 22:11:36]

Please add some form of verification of the out parameter.

Basically it should be one longer than |input_chain|, match on all those
elements, and then the last element should be the trusted certificate in
trust_store.

Can check the last one by using
TrustStore::IsTrustedCertificate(built_chain.back()) or something like that.

[ryanchung, 2016/06/16 22:47:08]

Done.

+                                       &signature_policy, time, nullptr);
 
   ASSERT_EQ(expected_result, result);
 }
 
 TEST(VerifyCertificateChainTest, TargetAndIntermediary) {
   RunTest("target-and-intermediary.pem");
 }
 
 TEST(VerifyCertificateChainTest, UnknownRoot) {
   RunTest("unknown-root.pem");
@@ skipping 99 matching lines @@
   RunTest("non-self-signed-root.pem");
 }
 
 // Tests that verifying a chain with no certificates fails.
 TEST(VerifyCertificateChainTest, EmptyChainIsInvalid) {
   TrustStore trust_store;
   der::GeneralizedTime time;
   std::vector<scoped_refptr<ParsedCertificate>> chain;
   SimpleSignaturePolicy signature_policy(2048);
 
-  ASSERT_FALSE(
-      VerifyCertificateChain(chain, trust_store, &signature_policy, time));
+  ASSERT_FALSE(VerifyCertificateChain(chain, trust_store, &signature_policy,
+                                      time, nullptr));
 }
 
 // TODO(eroman): Add test that invalidate validity dates where the day or month
 // ordinal not in range, like "March 39, 2016" are rejected.
 
 }  // namespace
 
 }  // namespace net