client/logdog/annotee/annotation/annotation.go - Issue 2078603002: milo: fix running steps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/logdog/annotee/annotation/annotation.go

Issue 2078603002: milo: fix running steps (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@milo-pending

Patch Set: address comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: client/logdog/annotee/annotation/annotation.go

diff --git a/client/logdog/annotee/annotation/annotation.go b/client/logdog/annotee/annotation/annotation.go

index 7542ea2927a11565f2bb33e455d169225bf017b4..13077ff1d3766da2ba59a1bc8ae0cec921d9fe38 100644

--- a/client/logdog/annotee/annotation/annotation.go

+++ b/client/logdog/annotee/annotation/annotation.go

@@ -607,7 +607,7 @@ func (as *Step) closeWithStatus(closeTime *google.Timestamp, sp *milo.Status) bo

}

- // Close any ourstanding log streams.

+ // Close any oustanding log streams.

for l := range as.logLines {

as.LogEnd(l)

}