Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: client/logdog/annotee/executor/executor.go

Issue 2078603002: milo: fix running steps (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@milo-pending
Patch Set: milo: fix running steps Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: client/logdog/annotee/executor/executor.go
diff --git a/client/logdog/annotee/executor/executor.go b/client/logdog/annotee/executor/executor.go
index 0e39ab0af68e7dd9d4f31b32d69d6892ae4e3d0d..2c57fe0e209a7bd52d883a01b61d03bbc8e15276 100644
--- a/client/logdog/annotee/executor/executor.go
+++ b/client/logdog/annotee/executor/executor.go
@@ -133,7 +133,7 @@ func (e *Executor) Run(ctx context.Context, command []string) error {
// If we fail to process the I/O, terminate the bootstrapped process
// immediately, since it may otherwise block forever on I/O.
proc := annotee.New(ctx, options)
- defer proc.Finish()
+ defer proc.Finish(options.CloseSteps)
if err := proc.RunStreams(streams); err != nil {
cancelFunc()
@@ -141,7 +141,7 @@ func (e *Executor) Run(ctx context.Context, command []string) error {
}
// Finish and record our annotation steps on completion.
- proc.Finish().ForEachStep(func(s *annotation.Step) {
+ proc.Finish(options.CloseSteps).ForEachStep(func(s *annotation.Step) {
e.steps = append(e.steps, s.Proto())
})
return nil

Powered by Google App Engine
This is Rietveld 408576698