Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2078563002:
[Android] Stop gtests & instrumentation tests on receiving SIGTERM. (Closed)
Description[Android] Stop gtests & instrumentation tests on receiving SIGTERM.
BUG=620723
Committed: https://crrev.com/5dc7bbe9e52fd447f0c54d52d671c7d00c962ea5
Cr-Commit-Position: refs/heads/master@{#400430}
Patch Set 1 #
Total comments: 1
Messages
Total messages: 21 (8 generated)
jbudorick@chromium.org changed reviewers: + mikecase@chromium.org
mikecase@google.com changed reviewers: + mikecase@google.com
https://codereview.chromium.org/2078563002/diff/1/build/android/pylib/local/d... File build/android/pylib/local/device/local_device_test_run.py (right): https://codereview.chromium.org/2078563002/diff/1/build/android/pylib/local/d... build/android/pylib/local/device/local_device_test_run.py:76: logging.exception('Shard killed: %s(%s)', f.__name__, str(dev)) Did anything functionally change except for adding this log statement? SIGTERM would kill all these threads anyways right?
On 2016/06/16 19:13:13, mikecase (wrong mikecase) wrote: > https://codereview.chromium.org/2078563002/diff/1/build/android/pylib/local/d... > File build/android/pylib/local/device/local_device_test_run.py (right): > > https://codereview.chromium.org/2078563002/diff/1/build/android/pylib/local/d... > build/android/pylib/local/device/local_device_test_run.py:76: > logging.exception('Shard killed: %s(%s)', f.__name__, str(dev)) > Did anything functionally change except for adding this log statement? SIGTERM > would kill all these threads anyways right? Nope.
On 2016/06/16 19:13:45, jbudorick wrote: > On 2016/06/16 19:13:13, mikecase (wrong mikecase) wrote: > > > https://codereview.chromium.org/2078563002/diff/1/build/android/pylib/local/d... > > File build/android/pylib/local/device/local_device_test_run.py (right): > > > > > https://codereview.chromium.org/2078563002/diff/1/build/android/pylib/local/d... > > build/android/pylib/local/device/local_device_test_run.py:76: > > logging.exception('Shard killed: %s(%s)', f.__name__, str(dev)) > > Did anything functionally change except for adding this log statement? SIGTERM > > would kill all these threads anyways right? > > Nope. (that is, no, it wouldn't kill these threads anyways)
in that case, lgtm
lgtm
The CQ bit was checked by jbudorick@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2078563002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
The CQ bit was checked by jbudorick@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2078563002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
The CQ bit was checked by jbudorick@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2078563002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [Android] Stop gtests & instrumentation tests on receiving SIGTERM. BUG=620723 ========== to ========== [Android] Stop gtests & instrumentation tests on receiving SIGTERM. BUG=620723 Committed: https://crrev.com/5dc7bbe9e52fd447f0c54d52d671c7d00c962ea5 Cr-Commit-Position: refs/heads/master@{#400430} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/5dc7bbe9e52fd447f0c54d52d671c7d00c962ea5 Cr-Commit-Position: refs/heads/master@{#400430} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
