Issue 2078553002: git cl upload: convert to print_function

Issue 2078553002: git cl upload: convert to print_function (Closed)

Created:
4 years, 6 months ago by vapier

Modified:
4 years, 6 months ago

Reviewers:
Vadim Sh., nodir

CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Target Ref:
refs/heads/master

Project:
depot_tools

Visibility:
Public.

git cl upload: convert to print_function This makes the code work both in python2 and python3. Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/c094376847f653294a282909d57fff2f6240f3ab

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -30 lines)			Patch
	M	third_party/upload.py	View		16 chunks	+33 lines, -30 lines	0 comments	Download

Total messages: 10 (4 generated)

Vadim Sh.

lgtm, but I'm not an OWNER +nodir, who's owner with low latency responses :)

4 years, 6 months ago (2016-06-16 18:24:24 UTC) #4

vapier

third_party/ has no OWNERS which means the top level should take effect which means you ...

4 years, 6 months ago (2016-06-16 18:38:11 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2078553002/1

4 years, 6 months ago (2016-06-16 18:38:15 UTC) #8

commit-bot: I haz the power

4 years, 6 months ago (2016-06-16 18:41:14 UTC) #10

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/c094376847f653...