src/gpu/vk/GrVkCaps.cpp - Issue 2078483002: Start using GrGpuCommandBuffer in GrDrawTarget.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/vk/GrVkCaps.cpp

Issue 2078483002: Start using GrGpuCommandBuffer in GrDrawTarget. (Closed) Base URL: https://skia.googlesource.com/skia.git@memoryWAR

Patch Set: review nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/vk/GrVkCaps.cpp

diff --git a/src/gpu/vk/GrVkCaps.cpp b/src/gpu/vk/GrVkCaps.cpp

index 60934de2a729c6ae02cef3082d5bbac68acc5971..89567c23f6b6dafd71144e349f15000d7b3c4497 100644

--- a/src/gpu/vk/GrVkCaps.cpp

+++ b/src/gpu/vk/GrVkCaps.cpp

@@ -31,7 +31,7 @@ GrVkCaps::GrVkCaps(const GrContextOptions& contextOptions, const GrVkInterface*

fCompressedTexSubImageSupport = false; //TODO: figure this out

fOversizedStencilSupport = false; //TODO: figure this out

- fUseDrawInsteadOfClear = false; //TODO: figure this out

+ fUseDrawInsteadOfClear = true; // Doing this temporarily to avoid clears in VkGpuCommandBuffer

fMapBufferFlags = kNone_MapFlags; //TODO: figure this out

fBufferMapThreshold = SK_MaxS32; //TODO: figure this out