src/gpu/vk/GrVkResourceProvider.cpp - Issue 2078483002: Start using GrGpuCommandBuffer in GrDrawTarget.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/vk/GrVkResourceProvider.cpp

Issue 2078483002: Start using GrGpuCommandBuffer in GrDrawTarget. (Closed) Base URL: https://skia.googlesource.com/skia.git@memoryWAR

Patch Set: Review updates Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/vk/GrVkResourceProvider.cpp

diff --git a/src/gpu/vk/GrVkResourceProvider.cpp b/src/gpu/vk/GrVkResourceProvider.cpp

index a632be44e22b4e54e28d17351e7689a6d1575c50..31d5568b603030046fcab264dd3a2194f578cc43 100644

--- a/src/gpu/vk/GrVkResourceProvider.cpp

+++ b/src/gpu/vk/GrVkResourceProvider.cpp

@@ -339,7 +339,7 @@ GrVkRenderPass* GrVkResourceProvider::CompatibleRenderPassSet::getRenderPass(

return fRenderPasses[idx];

}

- GrVkRenderPass* renderPass = fRenderPasses.push_back();

+ GrVkRenderPass* renderPass = fRenderPasses.emplace_back(new GrVkRenderPass());

renderPass->init(gpu, *this->getCompatibleRenderPass(), colorOps, resolveOps, stencilOps);

fLastReturnedIndex = fRenderPasses.count() - 1;

return renderPass;