Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2078443003: Convert media-element*, track-cue* and track-remove* tests to testharness.js (Closed)

Created:
4 years, 6 months ago by Srirama
Modified:
4 years, 6 months ago
Reviewers:
fs, foolip
CC:
fs, blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, gasubic, mlamouri+watch-blink_chromium.org, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert media-element*, track-cue* and track-remove* tests to testharness.js Cleaning up media-element*, track-cue* and track-remove* tests in media/track to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/2e0d99c0e86f5dc6624817f27ba76884f5cbbf83 Cr-Commit-Position: refs/heads/master@{#400393}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Use "onenter" event attribute #

Messages

Total messages: 12 (6 generated)
Srirama
PTAL https://codereview.chromium.org/2078443003/diff/1/third_party/WebKit/LayoutTests/media/track/track-cue-gc-wrapper.html File third_party/WebKit/LayoutTests/media/track/track-cue-gc-wrapper.html (right): https://codereview.chromium.org/2078443003/diff/1/third_party/WebKit/LayoutTests/media/track/track-cue-gc-wrapper.html#newcode26 third_party/WebKit/LayoutTests/media/track/track-cue-gc-wrapper.html:26: cue.addEventListener("enter", checkNativeProperty); I am not sure why using ...
4 years, 6 months ago (2016-06-16 13:30:45 UTC) #3
fs
lgtm https://codereview.chromium.org/2078443003/diff/1/third_party/WebKit/LayoutTests/media/track/track-cue-gc-wrapper.html File third_party/WebKit/LayoutTests/media/track/track-cue-gc-wrapper.html (right): https://codereview.chromium.org/2078443003/diff/1/third_party/WebKit/LayoutTests/media/track/track-cue-gc-wrapper.html#newcode26 third_party/WebKit/LayoutTests/media/track/track-cue-gc-wrapper.html:26: cue.addEventListener("enter", checkNativeProperty); On 2016/06/16 at 13:30:45, Srirama wrote: ...
4 years, 6 months ago (2016-06-16 22:58:50 UTC) #4
Srirama
https://codereview.chromium.org/2078443003/diff/1/third_party/WebKit/LayoutTests/media/track/track-cue-gc-wrapper.html File third_party/WebKit/LayoutTests/media/track/track-cue-gc-wrapper.html (right): https://codereview.chromium.org/2078443003/diff/1/third_party/WebKit/LayoutTests/media/track/track-cue-gc-wrapper.html#newcode26 third_party/WebKit/LayoutTests/media/track/track-cue-gc-wrapper.html:26: cue.addEventListener("enter", checkNativeProperty); On 2016/06/16 22:58:50, fs wrote: > On ...
4 years, 6 months ago (2016-06-17 06:30:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2078443003/20001
4 years, 6 months ago (2016-06-17 06:40:23 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-17 07:53:57 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 07:55:35 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2e0d99c0e86f5dc6624817f27ba76884f5cbbf83
Cr-Commit-Position: refs/heads/master@{#400393}

Powered by Google App Engine
This is Rietveld 408576698