Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2078423002: [turbofan] More efficient truncation analysis for add, sub. (Closed)

Created:
4 years, 6 months ago by Jarin
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] More efficient truncation analysis for add, sub. We now spread the word32 truncation even if the inputs can be minus zero as long as the result is not minus zero. Committed: https://crrev.com/398d131abac42e478780d9c23cf29caa1852fa0e Cr-Commit-Position: refs/heads/master@{#37102}

Patch Set 1 #

Patch Set 2 : Comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M src/compiler/simplified-lowering.cc View 1 2 chunks +6 lines, -5 lines 0 comments Download
M src/type-cache.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Jarin
Could you take a look, please?
4 years, 6 months ago (2016-06-20 11:42:51 UTC) #3
Benedikt Meurer
lgtm
4 years, 6 months ago (2016-06-20 11:56:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2078423002/20001
4 years, 6 months ago (2016-06-20 11:56:26 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-20 12:21:06 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 12:22:49 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/398d131abac42e478780d9c23cf29caa1852fa0e
Cr-Commit-Position: refs/heads/master@{#37102}

Powered by Google App Engine
This is Rietveld 408576698