Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 2078393003: Revert of Check DisplayItemCient aliveness in cached subsequences (Closed)

Created:
4 years, 6 months ago by vasilii
Modified:
4 years, 6 months ago
Reviewers:
chrishtr, Xianzhu
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Check DisplayItemCient aliveness in cached subsequences (patchset #6 id:100001 of https://codereview.chromium.org/2066603005/ ) Reason for revert: Based on r400605 that is to be reverted. Original issue's description: > Check DisplayItemCient aliveness in cached subsequences > > BUG=609218 > > Committed: https://crrev.com/127e5fadca5f431a5de1bef939f7f43aec1d136f > Cr-Commit-Position: refs/heads/master@{#400607} TBR=chrishtr@chromium.org,wangxianzhu@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=609218 Committed: https://chromium.googlesource.com/chromium/src/+/6ece4aaeb5e2c53eca2617d42de64ff917cee884

Patch Set 1 #

Messages

Total messages: 8 (3 generated)
vasilii
Created Revert of Check DisplayItemCient aliveness in cached subsequences
4 years, 6 months ago (2016-06-20 10:02:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2078393003/1
4 years, 6 months ago (2016-06-20 10:02:54 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6ece4aaeb5e2c53eca2617d42de64ff917cee884 Cr-Commit-Position: refs/heads/master@{#400644}
4 years, 6 months ago (2016-06-20 10:33:06 UTC) #5
vasilii
Committed patchset #1 (id:1) manually as 6ece4aaeb5e2c53eca2617d42de64ff917cee884 (presubmit successful).
4 years, 6 months ago (2016-06-20 10:33:54 UTC) #7
Yuta Kitamura
4 years, 6 months ago (2016-06-20 10:50:50 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2082553002/ by yutak@chromium.org.

The reason for reverting is: It was not acceptable to revert the OwnPtr removal
patch just for this revert.

Relanding this to land OwnPtr commit again..

Powered by Google App Engine
This is Rietveld 408576698