Add a BrowserViewRenderer unittest for compositor switch logic

content/public/test/test_synchronous_compositor_android.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/test/test_synchronous_compositor_android.h"
 
 #include <utility>
 
 #include "cc/output/compositor_frame.h"
 
 namespace content {
 
-TestSynchronousCompositor::TestSynchronousCompositor() : client_(NULL) {
-}
+TestSynchronousCompositor::TestSynchronousCompositor(int process_id,
+                                                     int routing_id)
+    : client_(NULL), process_id_(process_id), routing_id_(routing_id) {}
 
 TestSynchronousCompositor::~TestSynchronousCompositor() {
+  client_->DidDestroyCompositor(this, process_id_, routing_id_);
   SetClient(NULL);
 }
 
 void TestSynchronousCompositor::SetClient(SynchronousCompositorClient* client) {
+  client_ = client;
   if (client_)
-    client_->DidDestroyCompositor(this, 0, 0);
-  client_ = client;
-  if (client_) {
-    client_->DidInitializeCompositor(this, 0, 0);
-  }
+    client_->DidInitializeCompositor(this, process_id_, routing_id_);

[boliu, 2016/06/21 17:29:47]

did you have to rearrange this logic?

[hush (inactive), 2016/06/21 21:27:26]

well it's saner. And... it is better to separate them so that we can have a
state where there are 2 compositors alive, but one "active"
And you do need a place to notify the destruction of the current compositor,
otherwise the compositor_map_.empty() dcheck in ~BrowserViewRenderer won't pass.

[boliu, 2016/06/21 21:31:59]

Didn't SetClient(NULL) used to call DidDestroyCompositor though?

[hush (inactive), 2016/06/21 22:02:27]

ok. I reverted this bit.

 }
 
 SynchronousCompositor::Frame TestSynchronousCompositor::DemandDrawHw(
     const gfx::Size& surface_size,
     const gfx::Transform& transform,
     const gfx::Rect& viewport,
     const gfx::Rect& clip,
     const gfx::Rect& viewport_rect_for_tile_priority,
     const gfx::Transform& transform_for_tile_priority) {
   return std::move(hardware_frame_);
@@ skipping 27 matching lines @@
 
 TestSynchronousCompositor::ReturnedResources::ReturnedResources()
     : output_surface_id(0u) {}
 
 TestSynchronousCompositor::ReturnedResources::ReturnedResources(
     const ReturnedResources& other) = default;
 
 TestSynchronousCompositor::ReturnedResources::~ReturnedResources() {}
 
 }  // namespace content