V8GCController::gcEpilogue should not fire Oilpan's GC if GCs are forbidden

V8GCController::gcEpilogue should not fire Oilpan's GC if GCs are forbidden

BUG=613678
Committed: https://crrev.com/2b383e44008c0d30d7c73f71c028e30934823955
Cr-Commit-Position: refs/heads/master@{#400655}

[haraken, 2016-06-20 08:23:02]

haraken@chromium.org changed reviewers:
+ oilpan-reviews@chromium.org, sigbjornf@opera.com

[haraken, 2016-06-20 08:23:02]

PTAL

[sof, 2016-06-20 08:31:48]

lgtm

https://codereview.chromium.org/2078353002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp (right):

https://codereview.chromium.org/2078353002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp:356: if
(ThreadState::current() && !ThreadState::current()->isGCForbidden()) {
early return not feasible?

[haraken, 2016-06-20 08:36:19]

https://codereview.chromium.org/2078353002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp (right):

https://codereview.chromium.org/2078353002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp:356: if
(ThreadState::current() && !ThreadState::current()->isGCForbidden()) {
On 2016/06/20 08:31:47, sof wrote:
> early return not feasible?

Due to the TRACE_EVENT at line 393.

[haraken, 2016-06-20 08:36:28]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-06-20 08:36:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2078353002/1

[sof, 2016-06-20 08:39:01]

https://codereview.chromium.org/2078353002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp (right):

https://codereview.chromium.org/2078353002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp:356: if
(ThreadState::current() && !ThreadState::current()->isGCForbidden()) {
On 2016/06/20 08:36:19, haraken wrote:
> On 2016/06/20 08:31:47, sof wrote:
> > early return not feasible?
> 
> Due to the TRACE_EVENT at line 393.

Yes, but what counters do you need to update if no GC can run?

[haraken, 2016-06-20 09:19:05]

On 2016/06/20 08:39:01, sof wrote:
>
https://codereview.chromium.org/2078353002/diff/1/third_party/WebKit/Source/b...
> File third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp (right):
> 
>
https://codereview.chromium.org/2078353002/diff/1/third_party/WebKit/Source/b...
> third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp:356: if
> (ThreadState::current() && !ThreadState::current()->isGCForbidden()) {
> On 2016/06/20 08:36:19, haraken wrote:
> > On 2016/06/20 08:31:47, sof wrote:
> > > early return not feasible?
> > 
> > Due to the TRACE_EVENT at line 393.
> 
> Yes, but what counters do you need to update if no GC can run?

But the TRACE_EVENT is for V8's GC, not Oilpan's GC. So we need to run the event
regardless of whether Oilpan's GC is followed or not, right?

[commit-bot: I haz the power, 2016-06-20 11:50:32]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-20 11:52:01]

Description was changed from

==========
V8GCController::gcEpilogue should not fire Oilpan's GC if GCs are forbidden

BUG=613678
==========

to

==========
V8GCController::gcEpilogue should not fire Oilpan's GC if GCs are forbidden

BUG=613678

Committed: https://crrev.com/2b383e44008c0d30d7c73f71c028e30934823955
Cr-Commit-Position: refs/heads/master@{#400655}
==========

[commit-bot: I haz the power, 2016-06-20 11:52:02]

Patchset 1 (id:??) landed as
https://crrev.com/2b383e44008c0d30d7c73f71c028e30934823955
Cr-Commit-Position: refs/heads/master@{#400655}